Re: [PR] Record if block API has been used in SegmentInfo [lucene]

2023-10-25 Thread via GitHub
s1monw commented on PR #12685: URL: https://github.com/apache/lucene/pull/12685#issuecomment-1780091805 I pushed fixes... thanks @jpountz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Record if block API has been used in SegmentInfo [lucene]

2023-10-25 Thread via GitHub
jpountz commented on PR #12685: URL: https://github.com/apache/lucene/pull/12685#issuecomment-1779837662 FYI we've seen failures on TestIndexWriter recently, which are reproducible (e.g. https://ci-builds.apache.org/job/Lucene/job/Lucene-NightlyTests-9.x/720/). I ran git bisect and it poin

Re: [PR] Record if block API has been used in SegmentInfo [lucene]

2023-10-23 Thread via GitHub
s1monw merged PR #12685: URL: https://github.com/apache/lucene/pull/12685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Record if block API has been used in SegmentInfo [lucene]

2023-10-19 Thread via GitHub
jpountz commented on code in PR #12685: URL: https://github.com/apache/lucene/pull/12685#discussion_r1365023966 ## lucene/CHANGES.txt: ## @@ -147,9 +147,13 @@ API Changes New Features - + * GITHUB#12548: Added similarityToQueryVector API to compute vecto

Re: [PR] Record if block API has been used in SegmentInfo [lucene]

2023-10-18 Thread via GitHub
s1monw commented on PR #12685: URL: https://github.com/apache/lucene/pull/12685#issuecomment-1768768579 @jpountz I pushed new commits, wanna take a new look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Record if block API has been used in SegmentInfo [lucene]

2023-10-16 Thread via GitHub
jpountz commented on code in PR #12685: URL: https://github.com/apache/lucene/pull/12685#discussion_r1361188738 ## lucene/core/src/java/org/apache/lucene/index/SegmentInfo.java: ## @@ -153,6 +157,16 @@ public boolean getUseCompoundFile() { return isCompoundFile; } + /

Re: [PR] Record if block API has been used in SegmentInfo [lucene]

2023-10-16 Thread via GitHub
s1monw commented on code in PR #12685: URL: https://github.com/apache/lucene/pull/12685#discussion_r1360837043 ## lucene/core/src/java/org/apache/lucene/index/IndexWriter.java: ## @@ -3368,9 +3368,15 @@ public void addIndexesReaderMerge(MergePolicy.OneMerge merge) throws IOExce