msokolov merged PR #14049:
URL: https://github.com/apache/lucene/pull/14049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.ap
msokolov commented on PR #14049:
URL: https://github.com/apache/lucene/pull/14049#issuecomment-2528438728
makes sense, I'll add a CHANGES entry and commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
msokolov commented on PR #14049:
URL: https://github.com/apache/lucene/pull/14049#issuecomment-2525276990
Thank Simon, that's good feedback about avoiding randomization for these
tests. There's nothing to revert - this hasn't been committed, it's just github
running tests that is failing. I
s1monw commented on PR #14049:
URL: https://github.com/apache/lucene/pull/14049#issuecomment-2525074361
@msokolov I didn't invent this test. Yet, we never tested the current
version obeying with it's own BWC expecations. Please make sure nothing
randomizes anything in this test. BWC tests a
msokolov commented on PR #14049:
URL: https://github.com/apache/lucene/pull/14049#issuecomment-2524594249
Another test fails now (this is going to be fun, it's hard to ferret all
these things out proactively):
```
TestBasicBackwardsCompatibility > testIndexOldIndex {Lucene-Version:
msokolov commented on PR #14049:
URL: https://github.com/apache/lucene/pull/14049#issuecomment-2523957319
oops a test failed; my bad for only beasting the ones in core ... I'll look
at this one:
gradlew :lucene:join:test --tests
"org.apache.lucene.search.join.TestBlockJoin.testSi
msokolov opened a new pull request, #14049:
URL: https://github.com/apache/lucene/pull/14049
This adds the randomization to RandomCodec and addresses some test issues.
* In a few places I had to disable the randomization; basically wherever we
are carefully testing scores. In these ca
