Re: [PR] Prevent extra similarity computation for single-level graphs [lucene]

2023-12-01 Thread via GitHub
benwtrent merged PR #12866: URL: https://github.com/apache/lucene/pull/12866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

Re: [PR] Prevent extra similarity computation for single-level graphs [lucene]

2023-12-01 Thread via GitHub
kaivalnp commented on PR #12866: URL: https://github.com/apache/lucene/pull/12866#issuecomment-1836394910 Replicated [this commit](https://github.com/apache/lucene/commit/94b879a5) (which added the 9.9.0 entry) for 9.10.0 Please let me know if I missed something.. -- This is an automat

Re: [PR] Prevent extra similarity computation for single-level graphs [lucene]

2023-12-01 Thread via GitHub
benwtrent commented on PR #12866: URL: https://github.com/apache/lucene/pull/12866#issuecomment-1836322275 @kaivalnp you can add it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Prevent extra similarity computation for single-level graphs [lucene]

2023-12-01 Thread via GitHub
kaivalnp commented on PR #12866: URL: https://github.com/apache/lucene/pull/12866#issuecomment-1836321336 Thanks @benwtrent :) > But a CHANGES entry for Lucene 9.10 I did not see a section for "9.10" in the [current CHANGES.txt](https://github.com/apache/lucene/blob/b231e5b2132

Re: [PR] Prevent extra similarity computation for single-level graphs [lucene]

2023-12-01 Thread via GitHub
kaivalnp commented on code in PR #12866: URL: https://github.com/apache/lucene/pull/12866#discussion_r1412139289 ## lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java: ## @@ -100,19 +100,10 @@ private static void search( HnswGraphSearcher graphSearche

Re: [PR] Prevent extra similarity computation for single-level graphs [lucene]

2023-12-01 Thread via GitHub
benwtrent commented on code in PR #12866: URL: https://github.com/apache/lucene/pull/12866#discussion_r1412053821 ## lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java: ## @@ -100,19 +100,10 @@ private static void search( HnswGraphSearcher graphSearch

[PR] Prevent extra similarity computation for single-level graphs [lucene]

2023-12-01 Thread via GitHub
kaivalnp opened a new pull request, #12866: URL: https://github.com/apache/lucene/pull/12866 ### Description [`#findBestEntryPoint`](https://github.com/apache/lucene/blob/4bc7850465dfac9dc0638d9ee782007883869ffe/lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java#L