github-actions[bot] commented on PR #13187:
URL: https://github.com/apache/lucene/pull/13187#issuecomment-2060105283
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
benwtrent commented on PR #13187:
URL: https://github.com/apache/lucene/pull/13187#issuecomment-2031759399
I am sorry this work has stalled. But I have been iterating on
https://github.com/apache/lucene/pull/13200 for a week now. Its getting to a
palatable place.
--
This is an automated
github-actions[bot] commented on PR #13187:
URL: https://github.com/apache/lucene/pull/13187#issuecomment-2030835653
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
shubhamvishu commented on PR #13187:
URL: https://github.com/apache/lucene/pull/13187#issuecomment-2004568222
@benwtrent So should we instead wait for the pluggability support and
discard this for now? or Is it possible to go forward with this?
> What makes this PR doubly worrying is
benwtrent commented on PR #13187:
URL: https://github.com/apache/lucene/pull/13187#issuecomment-2004052748
> Though I'm not sure if this change conflicts with or makes things
difficult for the ongoing efforts to have pluggability (maybe @benwtrent would
be interested in sharing his thoughts
shubhamvishu commented on PR #13187:
URL: https://github.com/apache/lucene/pull/13187#issuecomment-2003991803
Thanks for the review @msokolov! The idea to make it pluggable seems
relevant and interesting. Currently it was not possible to use any custom
vector similarity function other than
msokolov commented on PR #13187:
URL: https://github.com/apache/lucene/pull/13187#issuecomment-2003799323
There is some discussion how to make similarities more pluggable
https://github.com/apache/lucene/issues/13182 that seems relevant. Part of the
idea there is to accept ordinal values ra
shubhamvishu opened a new pull request, #13187:
URL: https://github.com/apache/lucene/pull/13187
### Description
This PR allows passing a custom vector similarity function to DVS
implementations of `VectorSimilarityValuesSource` as opposed to current
behaviour which by default only a
