Re: [PR] Pack file pointers when merging BKD trees [lucene]

2025-04-05 Thread via GitHub
benwtrent commented on code in PR #14393: URL: https://github.com/apache/lucene/pull/14393#discussion_r2010085479 ## lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java: ## @@ -1961,7 +1989,7 @@ private void build( int leafCardinality = heapSource.computeCardin

Re: [PR] Pack file pointers when merging BKD trees [lucene]

2025-03-25 Thread via GitHub
iverase merged PR #14393: URL: https://github.com/apache/lucene/pull/14393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Pack file pointers when merging BKD trees [lucene]

2025-03-24 Thread via GitHub
iverase commented on code in PR #14393: URL: https://github.com/apache/lucene/pull/14393#discussion_r2010066670 ## lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java: ## @@ -596,9 +606,12 @@ private IORunnable writeField1Dim( MutablePointTree reader) th

Re: [PR] Pack file pointers when merging BKD trees [lucene]

2025-03-24 Thread via GitHub
jpountz commented on code in PR #14393: URL: https://github.com/apache/lucene/pull/14393#discussion_r2010004639 ## lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java: ## @@ -596,9 +606,12 @@ private IORunnable writeField1Dim( MutablePointTree reader) th

Re: [PR] Pack file pointers when merging BKD trees [lucene]

2025-03-24 Thread via GitHub
iverase commented on code in PR #14393: URL: https://github.com/apache/lucene/pull/14393#discussion_r2010030440 ## lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java: ## @@ -596,9 +606,12 @@ private IORunnable writeField1Dim( MutablePointTree reader) th

Re: [PR] Pack file pointers when merging BKD trees [lucene]

2025-03-24 Thread via GitHub
jpountz commented on code in PR #14393: URL: https://github.com/apache/lucene/pull/14393#discussion_r2010037158 ## lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java: ## @@ -596,9 +606,12 @@ private IORunnable writeField1Dim( MutablePointTree reader) th

[PR] Pack file pointers when merging BKD trees [lucene]

2025-03-23 Thread via GitHub
iverase opened a new pull request, #14393: URL: https://github.com/apache/lucene/pull/14393 We are currently using long arrays to hold file pointers. These arrays can get pretty big if the number of points is big which seems wasteful, moreover when those file pointers are monotonically incr