jainankitk commented on PR #14609:
URL: https://github.com/apache/lucene/pull/14609#issuecomment-2868309175
Thanks @ebradshaw for this change, and congratulations on your first
contribution in lucene! :)
--
This is an automated message from the Apache Git Service.
To respond to the messag
jainankitk merged PR #14609:
URL: https://github.com/apache/lucene/pull/14609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
jainankitk commented on code in PR #14609:
URL: https://github.com/apache/lucene/pull/14609#discussion_r2082377177
##
lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java:
##
@@ -580,4 +557,111 @@ public final String toString(String field) {
* @return human rea
jpountz commented on code in PR #14609:
URL: https://github.com/apache/lucene/pull/14609#discussion_r2081563312
##
lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java:
##
@@ -580,4 +534,114 @@ public final String toString(String field) {
* @return human readab
ebradshaw commented on code in PR #14609:
URL: https://github.com/apache/lucene/pull/14609#discussion_r2080658986
##
lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java:
##
@@ -580,4 +557,111 @@ public final String toString(String field) {
* @return human read
ebradshaw commented on PR #14609:
URL: https://github.com/apache/lucene/pull/14609#issuecomment-2864750920
I think we're good now. Let me know if you guys see anything else, and
thanks for the quick review!
--
This is an automated message from the Apache Git Service.
To respond to the me
ebradshaw commented on code in PR #14609:
URL: https://github.com/apache/lucene/pull/14609#discussion_r2080657472
##
lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java:
##
@@ -580,4 +557,111 @@ public final String toString(String field) {
* @return human read
jainankitk commented on code in PR #14609:
URL: https://github.com/apache/lucene/pull/14609#discussion_r2078631302
##
lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java:
##
@@ -580,4 +557,111 @@ public final String toString(String field) {
* @return human rea
jpountz commented on code in PR #14609:
URL: https://github.com/apache/lucene/pull/14609#discussion_r2074166256
##
lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java:
##
@@ -45,8 +49,8 @@
* For a single-dimensional field this query is a simple range query; in a
jpountz commented on PR #14609:
URL: https://github.com/apache/lucene/pull/14609#issuecomment-2852297311
+1 to do this
Feel free to ask me for a review on a PR if you'd live to give it a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
ebradshaw opened a new pull request, #14609:
URL: https://github.com/apache/lucene/pull/14609
Overrides rewrite in PointRangeQuery range to handle cases where the query
either fully contains or fully excludes all documents within the shard.
Often, particularly when using time based pa
11 matches
Mail list logo
