Re: [PR] Output binary doc values as hex array in SimpleTextCodec [lucene]

2024-01-12 Thread via GitHub
jpountz merged PR #12987: URL: https://github.com/apache/lucene/pull/12987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Output binary doc values as hex array in SimpleTextCodec [lucene]

2024-01-11 Thread via GitHub
msfroh commented on PR #12987: URL: https://github.com/apache/lucene/pull/12987#issuecomment-1888270133 Test failure is reproducible on main: https://github.com/apache/lucene/issues/13009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Output binary doc values as hex array in SimpleTextCodec [lucene]

2024-01-11 Thread via GitHub
msfroh commented on code in PR #12987: URL: https://github.com/apache/lucene/pull/12987#discussion_r1449507398 ## lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextDocValuesReader.java: ## @@ -329,9 +330,15 @@ public BytesRef apply(int docID) {

Re: [PR] Output binary doc values as hex array in SimpleTextCodec [lucene]

2024-01-11 Thread via GitHub
msfroh commented on code in PR #12987: URL: https://github.com/apache/lucene/pull/12987#discussion_r1449507398 ## lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextDocValuesReader.java: ## @@ -329,9 +330,15 @@ public BytesRef apply(int docID) {

Re: [PR] Output binary doc values as hex array in SimpleTextCodec [lucene]

2024-01-11 Thread via GitHub
jpountz commented on code in PR #12987: URL: https://github.com/apache/lucene/pull/12987#discussion_r1448975940 ## lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextDocValuesReader.java: ## @@ -329,9 +330,15 @@ public BytesRef apply(int docID) {

[PR] Output binary doc values as hex array in SimpleTextCodec [lucene]

2023-12-29 Thread via GitHub
msfroh opened a new pull request, #12987: URL: https://github.com/apache/lucene/pull/12987 ### Description Binary doc values were being written directly in SimpleTextCodec, though they may not be valid UTF-8 (i.e. they may not be "text"). This change encodes them as a string represen