vigyasharma commented on PR #14373:
URL: https://github.com/apache/lucene/pull/14373#issuecomment-2747063076
Changes merged. Thanks @DivyanshIITB !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
vigyasharma merged PR #14373:
URL: https://github.com/apache/lucene/pull/14373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene
vigyasharma commented on PR #14373:
URL: https://github.com/apache/lucene/pull/14373#issuecomment-2745914617
> I successfully ran `./gradlew tidy` and the built was successful.
Github build is still failing on spotless (formatting). `tidy` will change
and reformat offending files for
DivyanshIITB commented on PR #14373:
URL: https://github.com/apache/lucene/pull/14373#issuecomment-2746245859
> > I successfully ran `./gradlew tidy` and the built was successful.
>
> Github build is still failing on spotless (formatting). `tidy` will change
and reformat offending fil
DivyanshIITB commented on code in PR #14373:
URL: https://github.com/apache/lucene/pull/14373#discussion_r2009127681
##
lucene/CHANGES.txt:
##
@@ -35,6 +35,10 @@ Optimizations
-
* GITHUB#14011: Reduce allocation rate in HNSW concurrent merge. (Viliam
Durin
vigyasharma commented on code in PR #14373:
URL: https://github.com/apache/lucene/pull/14373#discussion_r2008971507
##
lucene/CHANGES.txt:
##
@@ -35,6 +35,10 @@ Optimizations
-
* GITHUB#14011: Reduce allocation rate in HNSW concurrent merge. (Viliam
Durina
vigyasharma commented on code in PR #14373:
URL: https://github.com/apache/lucene/pull/14373#discussion_r2008971160
##
lucene/core/src/java/org/apache/lucene/index/ParallelLeafReader.java:
##
@@ -348,15 +348,24 @@ public void prefetch(int docID) throws IOException {
@Over
DivyanshIITB commented on PR #14373:
URL: https://github.com/apache/lucene/pull/14373#issuecomment-2745182601
> Changes look good to me. Can you run `./gradlew tidy` to fix formatting
issues, and add a changes entry before we merge this?
I successfully ran `./gradlew tidy` and the bui
DivyanshIITB commented on code in PR #14373:
URL: https://github.com/apache/lucene/pull/14373#discussion_r2008721150
##
lucene/core/src/java/org/apache/lucene/index/ParallelLeafReader.java:
##
@@ -348,15 +348,24 @@ public void prefetch(int docID) throws IOException {
@Ove
vigyasharma commented on code in PR #14373:
URL: https://github.com/apache/lucene/pull/14373#discussion_r2008678599
##
lucene/core/src/java/org/apache/lucene/index/ParallelLeafReader.java:
##
@@ -348,15 +348,24 @@ public void prefetch(int docID) throws IOException {
@Over
DivyanshIITB commented on PR #14373:
URL: https://github.com/apache/lucene/pull/14373#issuecomment-2741117231
Just a gentle reminder
@vigyasharma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
DivyanshIITB opened a new pull request, #14373:
URL: https://github.com/apache/lucene/pull/14373
This PR optimizes ParallelLeafReader to avoid redundant term vector fetching.
- Replaces per-field term vector fetching with a single call per reader.
- Reduces complexity from O(n^2) to O(n
12 matches
Mail list logo