Re: [PR] Not maintain docBufferUpTo when only docs needed [lucene]

2025-01-30 Thread via GitHub
jpountz commented on PR #14164: URL: https://github.com/apache/lucene/pull/14164#issuecomment-2625125069 This seems to have introduced a bug: https://ci-builds.apache.org/job/Lucene/job/Lucene-Check-main/11964/. I think it's related to how advanceShallow() sometimes refills the buffer. --

Re: [PR] Not maintain docBufferUpTo when only docs needed [lucene]

2025-01-26 Thread via GitHub
jpountz commented on PR #14164: URL: https://github.com/apache/lucene/pull/14164#issuecomment-2614490264 Nightly benchmarks confirmed the speedup, I pushed an annotation. https://benchmarks.mikemccandless.com/CountOrMany.html -- This is an automated message from the Apache Git Service. To

Re: [PR] Not maintain docBufferUpTo when only docs needed [lucene]

2025-01-24 Thread via GitHub
gf2121 merged PR #14164: URL: https://github.com/apache/lucene/pull/14164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Not maintain docBufferUpTo when only docs needed [lucene]

2025-01-23 Thread via GitHub
jpountz commented on code in PR #14164: URL: https://github.com/apache/lucene/pull/14164#discussion_r1926977463 ## lucene/core/src/java/org/apache/lucene/codecs/lucene101/Lucene101PostingsReader.java: ## @@ -388,6 +388,7 @@ private enum DeltaEncoding { final boolean needsOf

[PR] Not maintain docBufferUpTo when only docs needed [lucene]

2025-01-23 Thread via GitHub
gf2121 opened a new pull request, #14164: URL: https://github.com/apache/lucene/pull/14164 The `docBufferUpTo` variable is mainly maintained to obtain the corresponding value of freq/pos buffer. We can avoid the maintaining when only docs needed. Result on `wikimediumall`: ```