Re: [PR] MultiTermQuery return null for ScoreSupplier [lucene]

2024-06-06 Thread via GitHub
mayya-sharipova merged PR #13454: URL: https://github.com/apache/lucene/pull/13454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lu

Re: [PR] MultiTermQuery return null for ScoreSupplier [lucene]

2024-06-06 Thread via GitHub
mayya-sharipova commented on code in PR #13454: URL: https://github.com/apache/lucene/pull/13454#discussion_r1630030925 ## lucene/CHANGES.txt: ## @@ -249,7 +249,7 @@ Improvements Optimizations - -(No changes) +* GITHUB#13454: MultiTermQuery return null fo

Re: [PR] MultiTermQuery return null for ScoreSupplier [lucene]

2024-06-06 Thread via GitHub
gsmiller commented on code in PR #13454: URL: https://github.com/apache/lucene/pull/13454#discussion_r1629951445 ## lucene/core/src/java/org/apache/lucene/search/AbstractMultiTermQueryConstantScoreWrapper.java: ## @@ -162,21 +163,29 @@ private WeightOrDocIdSetIterator rewrite(L

Re: [PR] MultiTermQuery return null for ScoreSupplier [lucene]

2024-06-05 Thread via GitHub
mayya-sharipova commented on PR #13454: URL: https://github.com/apache/lucene/pull/13454#issuecomment-2150704539 @jpountz Thanks for your feedback, I addressed it, and the code looks much better with your suggestions! -- This is an automated message from the Apache Git Service. To res

Re: [PR] MultiTermQuery return null for ScoreSupplier [lucene]

2024-06-05 Thread via GitHub
mayya-sharipova commented on code in PR #13454: URL: https://github.com/apache/lucene/pull/13454#discussion_r1628252725 ## lucene/core/src/java/org/apache/lucene/search/AbstractMultiTermQueryConstantScoreWrapper.java: ## @@ -232,12 +221,24 @@ public ScorerSupplier scorerSupplier

Re: [PR] MultiTermQuery return null for ScoreSupplier [lucene]

2024-06-05 Thread via GitHub
mayya-sharipova commented on code in PR #13454: URL: https://github.com/apache/lucene/pull/13454#discussion_r1628251924 ## lucene/core/src/java/org/apache/lucene/search/AbstractMultiTermQueryConstantScoreWrapper.java: ## @@ -153,39 +153,28 @@ protected abstract WeightOrDocIdSetI

Re: [PR] MultiTermQuery return null for ScoreSupplier [lucene]

2024-06-05 Thread via GitHub
jpountz commented on code in PR #13454: URL: https://github.com/apache/lucene/pull/13454#discussion_r1627942880 ## lucene/core/src/java/org/apache/lucene/search/AbstractMultiTermQueryConstantScoreWrapper.java: ## @@ -232,12 +221,24 @@ public ScorerSupplier scorerSupplier(LeafRea

Re: [PR] MultiTermQuery return null for ScoreSupplier [lucene]

2024-06-05 Thread via GitHub
mayya-sharipova commented on PR #13454: URL: https://github.com/apache/lucene/pull/13454#issuecomment-2150107425 @gsmiller @jpountz I don't know all the implications for this, so your feedback is welcome. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] MultiTermQuery return null for ScoreSupplier [lucene]

2024-06-05 Thread via GitHub
mayya-sharipova opened a new pull request, #13454: URL: https://github.com/apache/lucene/pull/13454 MultiTermQuery return null for ScoreSupplier if there are no terms in an index that match query terms. With the introduction of PR #12156 we saw degradation in performance of bool