Re: [PR] Move anonymous Weight implementation in PointRangeQuery to named class [lucene]

2024-09-17 Thread via GitHub
github-actions[bot] commented on PR #13711: URL: https://github.com/apache/lucene/pull/13711#issuecomment-2357244427 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Move anonymous Weight implementation in PointRangeQuery to named class [lucene]

2024-09-03 Thread via GitHub
jpountz commented on PR #13711: URL: https://github.com/apache/lucene/pull/13711#issuecomment-2327425891 Sorry, I don't think we should make Lucene's `Weight` implementations public. I looked up the OpenSearch issue, if I understand correctly, the problem you're trying to solve is tha

Re: [PR] Move anonymous Weight implementation in PointRangeQuery to named class [lucene]

2024-09-03 Thread via GitHub
jainankitk commented on PR #13711: URL: https://github.com/apache/lucene/pull/13711#issuecomment-2327098073 > I see from the linked issue that you would like to extend `PointRangeQuery`, but in general we don't like to think of our queries as being extensible. I wonder if you could do what

Re: [PR] Move anonymous Weight implementation in PointRangeQuery to named class [lucene]

2024-09-03 Thread via GitHub
jpountz commented on PR #13711: URL: https://github.com/apache/lucene/pull/13711#issuecomment-2326913351 I see from the linked issue that you would like to extend `PointRangeQuery`, but in general we don't like to think of our queries as being extensible. I wonder if you could do what you n

[PR] Move anonymous Weight implementation in PointRangeQuery to named class [lucene]

2024-09-03 Thread via GitHub
jainankitk opened a new pull request, #13711: URL: https://github.com/apache/lucene/pull/13711 ### Description Moves the anonymous `Weight` implementation in `PointRangeQuery#createWeight` to named class for better extensibility and resusability. -- This is an automated me