Re: [PR] Minor refactoring in ComponentTree [lucene]

2025-04-11 Thread via GitHub
stefanvodita merged PR #14474: URL: https://github.com/apache/lucene/pull/14474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

Re: [PR] Minor refactoring in ComponentTree [lucene]

2025-04-10 Thread via GitHub
jainankitk commented on PR #14474: URL: https://github.com/apache/lucene/pull/14474#issuecomment-2795420056 > Thank you for the prompt response! Could you also add an entry in CHANGES.txt? Thank you for a prompt review. Added the entry to CHANGES.txt -- This is an automated message

Re: [PR] Minor refactoring in ComponentTree [lucene]

2025-04-10 Thread via GitHub
stefanvodita commented on code in PR #14474: URL: https://github.com/apache/lucene/pull/14474#discussion_r2038545565 ## lucene/core/src/java/org/apache/lucene/geo/ComponentTree.java: ## @@ -26,6 +26,13 @@ * Construction takes {@code O(n log n)} time for sorting and tree const

Re: [PR] Minor refactoring in ComponentTree [lucene]

2025-04-10 Thread via GitHub
jainankitk commented on code in PR #14474: URL: https://github.com/apache/lucene/pull/14474#discussion_r2038491526 ## lucene/core/src/java/org/apache/lucene/geo/ComponentTree.java: ## @@ -26,6 +26,13 @@ * Construction takes {@code O(n log n)} time for sorting and tree constru

Re: [PR] Minor refactoring in ComponentTree [lucene]

2025-04-10 Thread via GitHub
jainankitk commented on code in PR #14474: URL: https://github.com/apache/lucene/pull/14474#discussion_r2038470766 ## lucene/core/src/java/org/apache/lucene/geo/ComponentTree.java: ## @@ -322,27 +317,7 @@ private static ComponentTree createTree( } final int mid = (low

Re: [PR] Minor refactoring in ComponentTree [lucene]

2025-04-10 Thread via GitHub
jainankitk commented on code in PR #14474: URL: https://github.com/apache/lucene/pull/14474#discussion_r2038461725 ## lucene/core/src/java/org/apache/lucene/geo/ComponentTree.java: ## @@ -92,11 +99,9 @@ public boolean contains(double x, double y) { } } if

Re: [PR] Minor refactoring in ComponentTree [lucene]

2025-04-10 Thread via GitHub
stefanvodita commented on code in PR #14474: URL: https://github.com/apache/lucene/pull/14474#discussion_r2038390465 ## lucene/core/src/java/org/apache/lucene/geo/ComponentTree.java: ## @@ -92,11 +99,9 @@ public boolean contains(double x, double y) { } } i

[PR] Minor refactoring in ComponentTree [lucene]

2025-04-10 Thread via GitHub
jainankitk opened a new pull request, #14474: URL: https://github.com/apache/lucene/pull/14474 ### Description Minor refactoring of `Comparator` in `ComponentTree` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi