kaivalnp commented on PR #13220:
URL: https://github.com/apache/lucene/pull/13220#issuecomment-2026920169
Created a follow-up to remove `TimeLimitingCollector` from `main` after
deprecation: #13243
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
jpountz merged PR #13220:
URL: https://github.com/apache/lucene/pull/13220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
jpountz commented on PR #13220:
URL: https://github.com/apache/lucene/pull/13220#issuecomment-2026847843
Thanks for confirming, I'll merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
vigyasharma commented on PR #13220:
URL: https://github.com/apache/lucene/pull/13220#issuecomment-2023475693
@jpountz I was checking for consensus. I'm aligned with deprecating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
jpountz commented on PR #13220:
URL: https://github.com/apache/lucene/pull/13220#issuecomment-2022882774
@vigyasharma I'd like to double check with you if you're good with
deprecating before merging, I'm not sure if your previous comment was candidly
checking for consensus, or if you were i
jpountz commented on PR #13220:
URL: https://github.com/apache/lucene/pull/13220#issuecomment-2021484078
It makes sense to me to deprecate it, `IndexSearcher#setTimeout` should be
used instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
vigyasharma commented on PR #13220:
URL: https://github.com/apache/lucene/pull/13220#issuecomment-2021304317
As an alternate to deprecating this entirely, we could also change it to
start using `QueryTimeout`, instead of its custom time limiting counters. I'd
like to get more opinions from
kaivalnp opened a new pull request, #13220:
URL: https://github.com/apache/lucene/pull/13220
### Description
Follow-up to
https://github.com/apache/lucene/pull/13202#issuecomment-2016947960
[`TimeLimitingCollector`](https://github.com/apache/lucene/blob/main/lucene/core/src/ja
