Re: [PR] Make PointValues.intersect iterative instead of recursive [lucene]

2025-03-27 Thread via GitHub
iverase commented on code in PR #14391: URL: https://github.com/apache/lucene/pull/14391#discussion_r2009830096 ## lucene/core/src/java/org/apache/lucene/index/PointValues.java: ## @@ -351,35 +351,32 @@ public final void intersect(IntersectVisitor visitor) throws IOException {

Re: [PR] Make PointValues.intersect iterative instead of recursive [lucene]

2025-03-25 Thread via GitHub
jpountz commented on PR #14391: URL: https://github.com/apache/lucene/pull/14391#issuecomment-2752592897 Nightly benchmarks report a tiny slowdown for IntNRQ and CountFilteredIntNRQ (https://benchmarks.mikemccandless.com/2025.03.24.18.05.19.html) nevertheless I agree with your point that it

Re: [PR] Make PointValues.intersect iterative instead of recursive [lucene]

2025-03-24 Thread via GitHub
original-brownbear commented on code in PR #14391: URL: https://github.com/apache/lucene/pull/14391#discussion_r2010353392 ## lucene/core/src/java/org/apache/lucene/index/PointValues.java: ## @@ -351,35 +351,32 @@ public final void intersect(IntersectVisitor visitor) throws IOE

Re: [PR] Make PointValues.intersect iterative instead of recursive [lucene]

2025-03-24 Thread via GitHub
original-brownbear merged PR #14391: URL: https://github.com/apache/lucene/pull/14391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

Re: [PR] Make PointValues.intersect iterative instead of recursive [lucene]

2025-03-24 Thread via GitHub
original-brownbear commented on PR #14391: URL: https://github.com/apache/lucene/pull/14391#issuecomment-2748319202 Thanks Ignacio! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co