Re: [PR] Make Operations#repeat create simpler automata. [lucene]

2024-09-04 Thread via GitHub
jpountz commented on PR #13714: URL: https://github.com/apache/lucene/pull/13714#issuecomment-2329450444 Good ideas, I'll look into it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Make Operations#repeat create simpler automata. [lucene]

2024-09-04 Thread via GitHub
mikemccand commented on code in PR #13714: URL: https://github.com/apache/lucene/pull/13714#discussion_r1743958059 ## lucene/core/src/java/org/apache/lucene/util/automaton/Operations.java: ## @@ -182,26 +182,44 @@ public static Automaton repeat(Automaton a) { // Repeating

Re: [PR] Make Operations#repeat create simpler automata. [lucene]

2024-09-04 Thread via GitHub
jpountz commented on PR #13714: URL: https://github.com/apache/lucene/pull/13714#issuecomment-2329331978 I just pushed a commit that avoids creating dead states if the input automaton doesn't have dead states itself. So the automaton created by `.*` would now have a single state. For

[PR] Make Operations#repeat create simpler automata. [lucene]

2024-09-04 Thread via GitHub
jpountz opened a new pull request, #13714: URL: https://github.com/apache/lucene/pull/13714 `Operations#repeat` currently creates an automaton that has one more final state, and 2x more transitions for each of the final states. With this change, the returned automaton has a single final sta