Re: [PR] Initial take at adding JMH micro-benchmarks [lucene]

dweiss commented on code in PR #12663: URL: https://github.com/apache/lucene/pull/12663#discussion_r1357235935 ## lucene/benchmark-jmh/README.txt: ## @@ -0,0 +1,21 @@ +The :lucene:benchmark-jmh module contains can be used to compile +and execute JMH (https://github.com/openjdk/j

Re: [PR] Initial take at adding JMH micro-benchmarks [lucene]

dweiss merged PR #12663: URL: https://github.com/apache/lucene/pull/12663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Initial take at adding JMH micro-benchmarks [lucene]

benwtrent commented on code in PR #12663: URL: https://github.com/apache/lucene/pull/12663#discussion_r1356970803 ## lucene/benchmark-jmh/README.txt: ## @@ -0,0 +1,21 @@ +The :lucene:benchmark-jmh module contains can be used to compile +and execute JMH (https://github.com/openjd

Re: [PR] Initial take at adding JMH micro-benchmarks [lucene]

benwtrent commented on PR #12663: URL: https://github.com/apache/lucene/pull/12663#issuecomment-1759795868 Looks good @dweiss I added a line with an example for running a single benchmark or suite of benchmarks. -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] Initial take at adding JMH micro-benchmarks [lucene]

dweiss commented on PR #12663: URL: https://github.com/apache/lucene/pull/12663#issuecomment-1759777296 @benwtrent Can you take a look? If there's any wording you think would work better, please do change it. Explaining how JMH works is perhaps beyond the scope of the readme file... ;) --

Re: [PR] Initial take at adding JMH micro-benchmarks [lucene]

dweiss commented on PR #12663: URL: https://github.com/apache/lucene/pull/12663#issuecomment-1759758762 I enabled forbiddenapis to the extent possible, to make Uwe happier. ;) I like those flame-graphs that Solr has, etc., but these can come later. I'll add a simple ```gradlew :helpJmh``` t

Re: [PR] Initial take at adding JMH micro-benchmarks [lucene]

benwtrent commented on PR #12663: URL: https://github.com/apache/lucene/pull/12663#issuecomment-1759752950 @dweiss one suggestion I have is adding a `README` for `lucene/benchmark-jmh` on how to run the benchmarks and add new ones. Your description on how to use it in this PR seems adequate

Re: [PR] Initial take at adding JMH micro-benchmarks [lucene]

benwtrent commented on PR #12663: URL: https://github.com/apache/lucene/pull/12663#issuecomment-1759607611 @dweiss this is awesome!!! Thank you so much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Initial take at adding JMH micro-benchmarks [lucene]

dweiss commented on PR #12663: URL: https://github.com/apache/lucene/pull/12663#issuecomment-1759605550 Let me review the minor remaining bits - I had to leave the computer before the tests completed. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Initial take at adding JMH micro-benchmarks [lucene]

rmuir commented on PR #12663: URL: https://github.com/apache/lucene/pull/12663#issuecomment-1759558774 @dweiss thank you for this! I tried it out and it works great. Glad to see the `cosineDistanceVectorUtil()` working in this example which is exactly what I want to do. -- This is an aut

[PR] Initial take at adding JMH micro-benchmarks [lucene]

dweiss opened a new pull request, #12663: URL: https://github.com/apache/lucene/pull/12663 As per discussion in: https://github.com/apache/lucene/issues/12641 This patch adds the ability to compile JMH microbenchmarks and run them from within Lucene codebase. I didn't use any plugins