Re: [PR] Include java21 source folders to gradle source sets [lucene]

javanna commented on PR #13926: URL: https://github.com/apache/lucene/pull/13926#issuecomment-2433270359 Thanks @dweiss ! Those manual steps worked for me as well. Good to know that there is at least a way to get the IDE to do something useful with those files, especially needing to make ch

Re: [PR] Include java21 source folders to gradle source sets [lucene]

dweiss commented on PR #13926: URL: https://github.com/apache/lucene/pull/13926#issuecomment-2427318916 Also - this basically adds syntax highlighting and suggestions, forget about running tests with these classes - I don't think it'll work from the IDE. -- This is an automated message fr

Re: [PR] Include java21 source folders to gradle source sets [lucene]

dweiss commented on PR #13926: URL: https://github.com/apache/lucene/pull/13926#issuecomment-2427276085 It is complicated also because there is some trickery in how Lucene compiles against those preview APIs - we don't use the preview option but instead fool the compiler into thinking these

Re: [PR] Include java21 source folders to gradle source sets [lucene]

javanna commented on PR #13926: URL: https://github.com/apache/lucene/pull/13926#issuecomment-2426005143 Yes @dweiss indeed it's complicated. I have tried manually and I did not succeed yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Include java21 source folders to gradle source sets [lucene]

dweiss commented on PR #13926: URL: https://github.com/apache/lucene/pull/13926#issuecomment-2423618479 Right... I forgot about that. If so then adding this to intellij will be even more complicated because it'd have to be another module, with a different set of compilation flags. Perhaps y

Re: [PR] Include java21 source folders to gradle source sets [lucene]

javanna commented on PR #13926: URL: https://github.com/apache/lucene/pull/13926#issuecomment-2423129841 > Thank you for addressing this! I wish I did! But I know that Chris has been looking at finding some solution around having IDEs import these classes as source sets. -- This is

Re: [PR] Include java21 source folders to gradle source sets [lucene]

javanna commented on PR #13926: URL: https://github.com/apache/lucene/pull/13926#issuecomment-2423128918 > (but java21 folders can definitely be folded in). I talked with @ChrisHegarty and he kindly explained that that is not the case. it's complicated :) While we are on java 21, thes

Re: [PR] Include java21 source folders to gradle source sets [lucene]

javanna closed pull request #13926: Include java21 source folders to gradle source sets URL: https://github.com/apache/lucene/pull/13926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Include java21 source folders to gradle source sets [lucene]

dweiss commented on PR #13926: URL: https://github.com/apache/lucene/pull/13926#issuecomment-2421818871 Thank you, Luka. I think we may want to keep the build infrastructure for mr-jars - just in case it comes in handy in the future. -- This is an automated message from the Apache Git Ser

Re: [PR] Include java21 source folders to gradle source sets [lucene]

dweiss commented on PR #13926: URL: https://github.com/apache/lucene/pull/13926#issuecomment-2421819235 (but java21 folders can definitely be folded in). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Include java21 source folders to gradle source sets [lucene]

javanna commented on PR #13926: URL: https://github.com/apache/lucene/pull/13926#issuecomment-2421592171 I will close this then and figure out a different change for branch_10x and main. Thanks for the help! -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] Include java21 source folders to gradle source sets [lucene]

msokolov commented on PR #13926: URL: https://github.com/apache/lucene/pull/13926#issuecomment-2420520325 Thank you for addressing this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Include java21 source folders to gradle source sets [lucene]

dweiss commented on PR #13926: URL: https://github.com/apache/lucene/pull/13926#issuecomment-2420026315 Yes, I think branch_10x is also on Java 21, minimum. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Include java21 source folders to gradle source sets [lucene]

javanna commented on PR #13926: URL: https://github.com/apache/lucene/pull/13926#issuecomment-2419544522 Thanks @dweiss for chiming in, I clearly don't know what I am doing here :) > The main branch should be on Java 21 anyway so we could just move those files to src? Wait, bra

Re: [PR] Include java21 source folders to gradle source sets [lucene]

javanna commented on PR #13926: URL: https://github.com/apache/lucene/pull/13926#issuecomment-2419374325 This change does make these file visible as source files in IntelliJ, which is the issue I meant to address. I do need to sort out the build issues that come up though with my change (la