Re: [PR] Improve VectorUtil::xorBitCount perf on ARM [lucene]

2024-07-09 Thread via GitHub
ChrisHegarty commented on code in PR #13545: URL: https://github.com/apache/lucene/pull/13545#discussion_r1670333682 ## lucene/core/src/java/org/apache/lucene/util/VectorUtil.java: ## @@ -212,6 +212,14 @@ public static int int4DotProductPacked(byte[] unpacked, byte[] packed) {

Re: [PR] Improve VectorUtil::xorBitCount perf on ARM [lucene]

2024-07-09 Thread via GitHub
ChrisHegarty commented on PR #13545: URL: https://github.com/apache/lucene/pull/13545#issuecomment-2216914939 @uschindler Apologies, I didn't notice this when cherrypicking. Thanks for reverting (while I was sleeping ;-) ) -- This is an automated message from the Apache Git Service. To re

Re: [PR] Improve VectorUtil::xorBitCount perf on ARM [lucene]

2024-07-08 Thread via GitHub
uschindler commented on PR #13545: URL: https://github.com/apache/lucene/pull/13545#issuecomment-2215482308 I reverted the addition of the file to 9.x branch: 86d080a4e0b4e53e0c9a3f2e2b120bff204c7276 -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Improve VectorUtil::xorBitCount perf on ARM [lucene]

2024-07-08 Thread via GitHub
uschindler commented on code in PR #13545: URL: https://github.com/apache/lucene/pull/13545#discussion_r1669064660 ## lucene/core/src/java/org/apache/lucene/util/VectorUtil.java: ## @@ -212,6 +212,14 @@ public static int int4DotProductPacked(byte[] unpacked, byte[] packed) {

Re: [PR] Improve VectorUtil::xorBitCount perf on ARM [lucene]

2024-07-08 Thread via GitHub
uschindler commented on PR #13545: URL: https://github.com/apache/lucene/pull/13545#issuecomment-2214846241 See: https://github.com/apache/lucene/commit/c8b4a76ecc93a98c779364b18f62c9b67552c192#diff-dd8d7417893f9b2fecaef29491b94d5daeaae6d496c4b21bb9633b4f7b060e59 -- This is an automated m

Re: [PR] Improve VectorUtil::xorBitCount perf on ARM [lucene]

2024-07-08 Thread via GitHub
uschindler commented on PR #13545: URL: https://github.com/apache/lucene/pull/13545#issuecomment-2214845553 Hi, in the backport to 9.x the benchmark file was wrongly merged. It landed in the test directory. In 9.x we have no benchmark-jmh module in Gradle, so the file should have been le

Re: [PR] Improve VectorUtil::xorBitCount perf on ARM [lucene]

2024-07-08 Thread via GitHub
ChrisHegarty merged PR #13545: URL: https://github.com/apache/lucene/pull/13545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen