rmuir commented on PR #14678:
URL: https://github.com/apache/lucene/pull/14678#issuecomment-2888550852
git log tells the story. A quick summary:
* conflicting use cases such as usages as a reference vs
stringbuilder/string type uses
* ownership issues and API problems resulting fro
rmuir commented on PR #14678:
URL: https://github.com/apache/lucene/pull/14678#issuecomment-2888555604
> In #12071 these is mention [#12071
(comment)](https://github.com/apache/lucene/issues/12071#issuecomment-1379313710)
of using the vector APIs to speed up UnicodeUtil conversions. Has any
schlosna commented on PR #14678:
URL: https://github.com/apache/lucene/pull/14678#issuecomment-2888508407
> There's intentionally not a `BytesRef(String)` constructor, as there have
been issues before.
@rmuir Do you happen to recall what issues a `BytesRef(String)` constructor
create
rmuir commented on PR #14678:
URL: https://github.com/apache/lucene/pull/14678#issuecomment-2888326775
There's intentionally not a `BytesRef(String)` constructor, as there have
been issues before.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
vigyasharma commented on code in PR #14678:
URL: https://github.com/apache/lucene/pull/14678#discussion_r2093976930
##
lucene/CHANGES.txt:
##
@@ -41,6 +41,7 @@ Optimizations
-
* GITHUB#14011: Reduce allocation rate in HNSW concurrent merge. (Viliam
Durina)
schlosna commented on PR #14678:
URL: https://github.com/apache/lucene/pull/14678#issuecomment-2887624646
Added `BytesRefBenchmark` demonstrating existing `new
BytesRef(CharSequence)` vs. `new BytesRef(String)` demonstrating 2x to 6x
throughput improvement on AMD EPYC 7R13 Processor:
github-actions[bot] commented on PR #14678:
URL: https://github.com/apache/lucene/pull/14678#issuecomment-2887298479
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog-check
label to it and you wil
github-actions[bot] commented on PR #14678:
URL: https://github.com/apache/lucene/pull/14678#issuecomment-2887286703
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog-check
label to it and you wil
