benwtrent merged PR #13322:
URL: https://github.com/apache/lucene/pull/13322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
jpountz commented on code in PR #13322:
URL: https://github.com/apache/lucene/pull/13322#discussion_r1627993328
##
lucene/core/src/java/org/apache/lucene/search/FieldExistsQuery.java:
##
@@ -277,4 +276,20 @@ private String buildErrorMsg(FieldInfo fieldInfo) {
+ fieldInf
bugmakerr commented on PR #13322:
URL: https://github.com/apache/lucene/pull/13322#issuecomment-2150212641
@benwtrent done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
benwtrent commented on PR #13322:
URL: https://github.com/apache/lucene/pull/13322#issuecomment-2149930924
@bugmakerr Once you handle the conflicts, I can merge and backport. I
think this is ready to go unless @jpountz has any outstanding concerns.
--
This is an automated message from
bugmakerr commented on code in PR #13322:
URL: https://github.com/apache/lucene/pull/13322#discussion_r1625261750
##
lucene/CHANGES.txt:
##
@@ -399,6 +399,8 @@ Optimizations
* GITHUB#13406: Replace List by IntArrayList and List by
LongArrayList. (Bruno Roustant)
+* GIT
benwtrent commented on code in PR #13322:
URL: https://github.com/apache/lucene/pull/13322#discussion_r1624971924
##
lucene/CHANGES.txt:
##
@@ -399,6 +399,8 @@ Optimizations
* GITHUB#13406: Replace List by IntArrayList and List by
LongArrayList. (Bruno Roustant)
+* GITHUB#
bugmakerr commented on PR #13322:
URL: https://github.com/apache/lucene/pull/13322#issuecomment-210261
@jpountz could you please take a look when you get a chance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
github-actions[bot] commented on PR #13322:
URL: https://github.com/apache/lucene/pull/13322#issuecomment-2143642763
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
bugmakerr commented on PR #13322:
URL: https://github.com/apache/lucene/pull/13322#issuecomment-2096390961
> I don't remember how vectors handle ghost fields, could this trigger a NPE
if a field indexes vectors, then all docs that have vectors get merged away?
The test shows that
benwtrent commented on PR #13322:
URL: https://github.com/apache/lucene/pull/13322#issuecomment-2075509191
I like this. Could you add an entry under "Optimizations" in "CHANGES.txt"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
bugmakerr opened a new pull request, #13322:
URL: https://github.com/apache/lucene/pull/13322
### Description
Considering only one vector value can be indexed per doc, we can use the
Float/ByteVectorValues#size method to implement Weight#count for vector values
in the FieldEx
11 matches
Mail list logo
