stefanvodita closed pull request #13740: Have value and count in LabelAndValue
only for TaxonomyFacets
URL: https://github.com/apache/lucene/pull/13740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
stefanvodita commented on PR #13740:
URL: https://github.com/apache/lucene/pull/13740#issuecomment-2416197652
I like progress-not-perfection, but looking at this again I'm not sure it's
progress. To me, it seems like a lot of complexity for a little bit of
efficiency, but I could be wrong.
stefanvodita commented on PR #13740:
URL: https://github.com/apache/lucene/pull/13740#issuecomment-2367820490
> Given the timing of 9.12/10.0, I'm not sure we should rush this in? Can we
aim for 10.1.0? Are these @lucene.experimental APIs so we are free to break in
the 10.x series?
`
mikemccand commented on code in PR #13740:
URL: https://github.com/apache/lucene/pull/13740#discussion_r1770557016
##
lucene/facet/src/java/org/apache/lucene/facet/LabelAndValue.java:
##
@@ -52,11 +41,81 @@ public boolean equals(Object _other) {
return false;
}
github-actions[bot] commented on PR #13740:
URL: https://github.com/apache/lucene/pull/13740#issuecomment-2365376489
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
