Re: [PR] GITHUB#13175: Stop double-checking priority queue inserts [lucene]

2024-06-15 Thread via GitHub
slow-J commented on code in PR #13488: URL: https://github.com/apache/lucene/pull/13488#discussion_r1640951451 ## lucene/CHANGES.txt: ## @@ -273,6 +273,8 @@ Optimizations * GITHUB#13431: Replace TreeMap and use compiled Patterns in Japanese UserDictionary. (Bruno Roustant)

Re: [PR] GITHUB#13175: Stop double-checking priority queue inserts [lucene]

2024-06-14 Thread via GitHub
mikemccand commented on code in PR #13488: URL: https://github.com/apache/lucene/pull/13488#discussion_r1640756284 ## lucene/CHANGES.txt: ## @@ -273,6 +273,8 @@ Optimizations * GITHUB#13431: Replace TreeMap and use compiled Patterns in Japanese UserDictionary. (Bruno Roustan

[PR] GITHUB#13175: Stop double-checking priority queue inserts [lucene]

2024-06-14 Thread via GitHub
slow-J opened a new pull request, #13488: URL: https://github.com/apache/lucene/pull/13488 Removing 2 cases of bottomX optimizations where insertWithOverflow already handles the check. Closes #13175 The diff looks funny because of unnesting, but, per file, I am just removing