benwtrent merged PR #14420:
URL: https://github.com/apache/lucene/pull/14420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
tveasey commented on PR #14420:
URL: https://github.com/apache/lucene/pull/14420#issuecomment-2761706401
I discussed this a bit with Mayya.
So the underlying issue is how we account for the gain for degree 1
vertices. We say that the gain contribution from any vertex is at least 2, i.
mayya-sharipova commented on PR #14420:
URL: https://github.com/apache/lucene/pull/14420#issuecomment-2761615009
@benwtrent Please go ahead with a fix. Confirmed with @tveasey, algorithm's
author.
But we also look further into it. In this particular test, graphs are
unusual (small gr
benwtrent commented on PR #14420:
URL: https://github.com/apache/lucene/pull/14420#issuecomment-2761394895
> Does this case actually only happen when docs are reordered, or is it a
general edge case that we happened to find on a test run when docs happened to
be reordered?
I think it
jpountz commented on PR #14420:
URL: https://github.com/apache/lucene/pull/14420#issuecomment-2761367741
Does this case actually only happen when docs are reordered, or is it a
general edge case that we happened to find on a test run when docs happened to
be reordered?
--
This is an auto
benwtrent commented on PR #14420:
URL: https://github.com/apache/lucene/pull/14420#issuecomment-2761161246
//cc @iverase as you are handling the 10.2 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
benwtrent opened a new pull request, #14420:
URL: https://github.com/apache/lucene/pull/14420
It seems there are edge cases when the heap is empty. This prevents us from
attempting to pop from an empty heap.
This bug fix should go into 10.2 to make the 10.2.0 release.
closes: h
