Re: [PR] Fix test failure on TestPoint#testEqualsAndHashCode [lucene]

2024-06-02 Thread via GitHub
easyice merged PR #13433: URL: https://github.com/apache/lucene/pull/13433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Fix test failure on TestPoint#testEqualsAndHashCode [lucene]

2024-06-02 Thread via GitHub
easyice commented on PR #13433: URL: https://github.com/apache/lucene/pull/13433#issuecomment-2144176070 Thanks for reviewing, Mike! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Fix test failure on TestPoint#testEqualsAndHashCode [lucene]

2024-05-30 Thread via GitHub
easyice commented on PR #13433: URL: https://github.com/apache/lucene/pull/13433#issuecomment-2139548520 Maybe we don't need to fix the other tests right now, unless they really encounter hash collisions. -- This is an automated message from the Apache Git Service. To respond to the messa

[PR] Fix test failure on TestPoint#testEqualsAndHashCode [lucene]

2024-05-29 Thread via GitHub
easyice opened a new pull request, #13433: URL: https://github.com/apache/lucene/pull/13433 If two objects are different, it might have the same hashcode. in this case, `Point(-180.0,90.0)` and `Point(180.0,-90.0)` will have the same hashcode value. ``` org.apache.lucene.geo.Test