Re: [PR] Fix position increment in (Reverse)PathHierarchyTokenizer [lucene]

mikemccand merged PR #12875: URL: https://github.com/apache/lucene/pull/12875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

Re: [PR] Fix position increment in (Reverse)PathHierarchyTokenizer [lucene]

mikemccand commented on PR #12875: URL: https://github.com/apache/lucene/pull/12875#issuecomment-1860545292 Thanks @lukas-vlcek -- looks great -- no need to squash, I'll take care during merge. Exciting improvement, finally! -- This is an automated message from the Apache Git Service. To

Re: [PR] Fix position increment in (Reverse)PathHierarchyTokenizer [lucene]

lukas-vlcek commented on PR #12875: URL: https://github.com/apache/lucene/pull/12875#issuecomment-1860204767 @mikemccand Thanks for review. Done! Shall I squash all commits are will you do it when merging in GH? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Fix position increment in (Reverse)PathHierarchyTokenizer [lucene]

mikemccand commented on PR #12875: URL: https://github.com/apache/lucene/pull/12875#issuecomment-1856089585 > I am looking at `TestUnifiedHighlighter*` tests. Does it mean that I need to use specific fieldType? Can I use any fieldType(s) from existing `UHTestHelper.parametersFactoryList()`?

Re: [PR] Fix position increment in (Reverse)PathHierarchyTokenizer [lucene]

lukas-vlcek commented on PR #12875: URL: https://github.com/apache/lucene/pull/12875#issuecomment-1847241112 @mikemccand Do you think you can give me some hint about? > (e.g. `UnifiedHighlighter`, in certain modes) I am looking at `TestUnifiedHighlighter*` tests. Does it mean th

Re: [PR] Fix position increment in (Reverse)PathHierarchyTokenizer [lucene]

lukas-vlcek commented on PR #12875: URL: https://github.com/apache/lucene/pull/12875#issuecomment-1845620998 > Note that this should make highlighting based on postings offsets (e.g. UnifiedHighlighter, in certain modes) work on such fields when it does not today. Ture... so it sound

Re: [PR] Fix position increment in (Reverse)PathHierarchyTokenizer [lucene]

mikemccand commented on PR #12875: URL: https://github.com/apache/lucene/pull/12875#issuecomment-1845294522 Thanks for tackling this @lukas-vlcek and @msfroh! I left a couple small comments, but otherwise it looks great. Given that this alters the indexed tokens (makes them non-overl

Re: [PR] Fix position increment in (Reverse)PathHierarchyTokenizer [lucene]

mikemccand commented on code in PR #12875: URL: https://github.com/apache/lucene/pull/12875#discussion_r1418918500 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/path/ReversePathHierarchyTokenizer.java: ## @@ -158,10 +161,9 @@ public final boolean incrementToken()

Re: [PR] Fix position increment in (Reverse)PathHierarchyTokenizer [lucene]

mikemccand commented on code in PR #12875: URL: https://github.com/apache/lucene/pull/12875#discussion_r1418918221 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/path/PathHierarchyTokenizer.java: ## @@ -112,11 +115,8 @@ public PathHierarchyTokenizer( public fin

[PR] Fix position increment in (Reverse)PathHierarchyTokenizer [lucene]

lukas-vlcek opened a new pull request, #12875: URL: https://github.com/apache/lucene/pull/12875 ### Description Incrementing position attribute for each token in both `PathHieararchyTokenizer` and `ReversePathHieararchyTokenizer`. This change makes it possible to use both tokenizer