Re: [PR] Fix intermittently failing TestParallelLeafReader [lucene]

2023-12-02 Thread via GitHub
uschindler commented on PR #12865: URL: https://github.com/apache/lucene/pull/12865#issuecomment-1837134618 For ParallelCompositeReader tests the LogDoc policy is the only correct one (see documentation). But I agree, _this_ test does forceMerge to create a single segment index, so s

Re: [PR] Fix intermittently failing TestParallelLeafReader [lucene]

2023-12-02 Thread via GitHub
jpountz commented on PR #12865: URL: https://github.com/apache/lucene/pull/12865#issuecomment-1837132961 Thanks for fixing! FYI LuceneTestCase even has `newLogMergePolicy()` for cases like this when the test doesn't want the doc ID order to change through merging because of either TieredMer

Re: [PR] Fix intermittently failing TestParallelLeafReader [lucene]

2023-12-02 Thread via GitHub
ChrisHegarty merged PR #12865: URL: https://github.com/apache/lucene/pull/12865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

Re: [PR] Fix intermittently failing TestParallelLeafReader [lucene]

2023-12-02 Thread via GitHub
ChrisHegarty commented on PR #12865: URL: https://github.com/apache/lucene/pull/12865#issuecomment-1837103812 That's a good idea @uschindler - updated. The test passes successfully when run in a repeat loop. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] Fix intermittently failing TestParallelLeafReader [lucene]

2023-12-02 Thread via GitHub
uschindler commented on PR #12865: URL: https://github.com/apache/lucene/pull/12865#issuecomment-1837102840 See the documentation of class: https://lucene.apache.org/core/9_8_0/core/org/apache/lucene/index/ParallelCompositeReader.html -- This is an automated message from the Apache Git Se

Re: [PR] Fix intermittently failing TestParallelLeafReader [lucene]

2023-12-01 Thread via GitHub
ChrisHegarty commented on PR #12865: URL: https://github.com/apache/lucene/pull/12865#issuecomment-1836024282 The test was previously seen to fail about 1 in every couple of hundred runs, with: ``` org.junit.ComparisonFailure: expected: but was: at __randomizedtesting.SeedInfo.

[PR] Fix intermittently failing TestParallelLeafReader [lucene]

2023-12-01 Thread via GitHub
ChrisHegarty opened a new pull request, #12865: URL: https://github.com/apache/lucene/pull/12865 This commit fixes the intermittently failing TestParallelLeafReader. The ParallelLeafReader requires the document order to be consistent across indexes - each document contains the union o