benwtrent merged PR #12922:
URL: https://github.com/apache/lucene/pull/12922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
benwtrent commented on code in PR #12922:
URL: https://github.com/apache/lucene/pull/12922#discussion_r1424532683
##
lucene/core/src/java/org/apache/lucene/search/AbstractVectorSimilarityQuery.java:
##
@@ -255,6 +255,11 @@ static VectorSimilarityScorer fromAcceptDocs(
kaivalnp commented on code in PR #12922:
URL: https://github.com/apache/lucene/pull/12922#discussion_r1424385137
##
lucene/core/src/java/org/apache/lucene/search/AbstractVectorSimilarityQuery.java:
##
@@ -255,6 +255,11 @@ static VectorSimilarityScorer fromAcceptDocs(
kaivalnp commented on code in PR #12922:
URL: https://github.com/apache/lucene/pull/12922#discussion_r1424377622
##
lucene/core/src/java/org/apache/lucene/search/AbstractVectorSimilarityQuery.java:
##
@@ -255,6 +255,11 @@ static VectorSimilarityScorer fromAcceptDocs(
benwtrent commented on code in PR #12922:
URL: https://github.com/apache/lucene/pull/12922#discussion_r1423943933
##
lucene/core/src/java/org/apache/lucene/search/AbstractVectorSimilarityQuery.java:
##
@@ -255,6 +255,11 @@ static VectorSimilarityScorer fromAcceptDocs(
kaivalnp opened a new pull request, #12922:
URL: https://github.com/apache/lucene/pull/12922
Discovered in #12921, and introduced in #12679
The first issue is that we weren't advancing the `VectorScorer`
[here](https://github.com/apache/lucene/blob/cf13a9295052288b748ed8f279f05ee26f3
