Re: [PR] Fix equals/hashcode of IOContext [lucene]

2024-03-23 Thread via GitHub
uschindler merged PR #13204: URL: https://github.com/apache/lucene/pull/13204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

Re: [PR] Fix equals/hashcode of IOContext [lucene]

2024-03-23 Thread via GitHub
uschindler commented on PR #13204: URL: https://github.com/apache/lucene/pull/13204#issuecomment-2016450251 Will open a PR directly after this was merged. The change to "record" kills almost half of the code. I just have to restore the missing ctors. -- This is an automated message from t

Re: [PR] Fix equals/hashcode of IOContext [lucene]

2024-03-23 Thread via GitHub
ChrisHegarty commented on PR #13204: URL: https://github.com/apache/lucene/pull/13204#issuecomment-2016449070 Looks like a good candidate for a record class alright, but that can come separate to the bug fix. -- This is an automated message from the Apache Git Service. To respond to the m