mikemccand commented on PR #14627:
URL: https://github.com/apache/lucene/pull/14627#issuecomment-2863041997
> I am out for lunch and only have my smartphone so can't cherry 🍒 pick to
stable branch. Will do this when back at home, unless somebody wants to step in
to silence Jenkins.
uschindler commented on code in PR #14627:
URL: https://github.com/apache/lucene/pull/14627#discussion_r2079584683
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/WindowsFS.java:
##
@@ -58,7 +58,13 @@ private Object getKey(Path existing) throws IOException {
uschindler commented on PR #14627:
URL: https://github.com/apache/lucene/pull/14627#issuecomment-2862891006
I am out for lunch and only have my smartphone so can't cherry 🍒 pick to
stable branch. Will do this when back at home, unless somebody wants to step in
to silence Jenkins.
--
This
uschindler merged PR #14627:
URL: https://github.com/apache/lucene/pull/14627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
uschindler commented on code in PR #14627:
URL: https://github.com/apache/lucene/pull/14627#discussion_r2079568663
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/WindowsFS.java:
##
@@ -58,7 +58,13 @@ private Object getKey(Path existing) throws IOException {
uschindler commented on code in PR #14627:
URL: https://github.com/apache/lucene/pull/14627#discussion_r2079584683
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/WindowsFS.java:
##
@@ -58,7 +58,13 @@ private Object getKey(Path existing) throws IOException {
uschindler commented on code in PR #14627:
URL: https://github.com/apache/lucene/pull/14627#discussion_r2079517705
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/WindowsFS.java:
##
@@ -58,7 +58,13 @@ private Object getKey(Path existing) throws IOException {
uschindler commented on code in PR #14627:
URL: https://github.com/apache/lucene/pull/14627#discussion_r2079572577
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/WindowsFS.java:
##
@@ -58,7 +58,13 @@ private Object getKey(Path existing) throws IOException {
rmuir commented on code in PR #14627:
URL: https://github.com/apache/lucene/pull/14627#discussion_r2079524379
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/WindowsFS.java:
##
@@ -58,7 +58,13 @@ private Object getKey(Path existing) throws IOException {
B
uschindler opened a new pull request, #14627:
URL: https://github.com/apache/lucene/pull/14627
Windows does not support file keys (the attribute returns null). Therefore
WindowsFS cannot be used on Windows. Due to Windows 11 no longer preventing
depleting of open files, we need to be able t
uschindler commented on code in PR #14627:
URL: https://github.com/apache/lucene/pull/14627#discussion_r2079517705
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/WindowsFS.java:
##
@@ -58,7 +58,13 @@ private Object getKey(Path existing) throws IOException {
rmuir commented on code in PR #14627:
URL: https://github.com/apache/lucene/pull/14627#discussion_r2079522011
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/WindowsFS.java:
##
@@ -58,7 +58,13 @@ private Object getKey(Path existing) throws IOException {
B
uschindler commented on code in PR #14627:
URL: https://github.com/apache/lucene/pull/14627#discussion_r2079517705
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/WindowsFS.java:
##
@@ -58,7 +58,13 @@ private Object getKey(Path existing) throws IOException {
uschindler commented on PR #14627:
URL: https://github.com/apache/lucene/pull/14627#issuecomment-2862686086
Theres one small problem that makes one test fail. ACtually the backslash is
a reserved character (if used in Unix), but on Windows, it is actually the file
separator.
I will a
uschindler commented on PR #14627:
URL: https://github.com/apache/lucene/pull/14627#issuecomment-2862658443
I'll will merge this after the tests pass here. Let's see how it behaves
long term.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
uschindler commented on PR #14627:
URL: https://github.com/apache/lucene/pull/14627#issuecomment-2862561374
It also works on my local Windows 11 machine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
uschindler commented on PR #14627:
URL: https://github.com/apache/lucene/pull/14627#issuecomment-2862560596
Hi,
it looks like all works well with Windows and WindowsFS.
For now I left the `toReal()` path in the key generation. I am still unsure
if it won't be enough to use the plai
uschindler commented on PR #14627:
URL: https://github.com/apache/lucene/pull/14627#issuecomment-2862430259
I was able to remove the assume on more tests.
Basically we should posisbly now also automatically enable WindowsFS
randomly for windows, too. Will add a followup commit once Gi
uschindler commented on code in PR #14627:
URL: https://github.com/apache/lucene/pull/14627#discussion_r2079320706
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/WindowsFS.java:
##
@@ -58,7 +58,13 @@ private Object getKey(Path existing) throws IOException {
uschindler commented on PR #14627:
URL: https://github.com/apache/lucene/pull/14627#issuecomment-2862406919
@rmuir : It also works with the path (without realpath). Maybe we can just
fallback to the path instead of realpath. It should be good enough, too and
reduces overhead.
What do
uschindler commented on PR #14627:
URL: https://github.com/apache/lucene/pull/14627#issuecomment-2862379899
Looks like it also passes with Windows 10 / Windows server 2022 (as used by
Github).
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
21 matches
Mail list logo
