Re: [PR] Fix TestIndexWriterOnError.testIOError failure. [lucene]

2024-05-29 Thread via GitHub
jpountz merged PR #13436: URL: https://github.com/apache/lucene/pull/13436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Fix TestIndexWriterOnError.testIOError failure. [lucene]

2024-05-29 Thread via GitHub
jpountz commented on code in PR #13436: URL: https://github.com/apache/lucene/pull/13436#discussion_r1619417391 ## lucene/core/src/java/org/apache/lucene/index/SegmentDocValues.java: ## @@ -76,10 +76,12 @@ synchronized DocValuesProducer getDocValuesProducer( /** Decrement t

Re: [PR] Fix TestIndexWriterOnError.testIOError failure. [lucene]

2024-05-29 Thread via GitHub
bruno-roustant commented on code in PR #13436: URL: https://github.com/apache/lucene/pull/13436#discussion_r1619393930 ## lucene/core/src/java/org/apache/lucene/index/SegmentDocValues.java: ## @@ -76,10 +76,12 @@ synchronized DocValuesProducer getDocValuesProducer( /** Decr

Re: [PR] Fix TestIndexWriterOnError.testIOError failure. [lucene]

2024-05-29 Thread via GitHub
benwtrent commented on code in PR #13436: URL: https://github.com/apache/lucene/pull/13436#discussion_r1619307513 ## lucene/core/src/java/org/apache/lucene/index/SegmentDocValues.java: ## @@ -76,10 +76,12 @@ synchronized DocValuesProducer getDocValuesProducer( /** Decrement

[PR] Fix TestIndexWriterOnError.testIOError failure. [lucene]

2024-05-29 Thread via GitHub
jpountz opened a new pull request, #13436: URL: https://github.com/apache/lucene/pull/13436 Pull request #13406 inadvertly broke Lucene's handling of tragic exceptions by stopping after the first `DocValuesProducer` whose `close()` calls throws an exception, instead of keeping calling `clos