stefanvodita commented on PR #13028:
URL: https://github.com/apache/lucene/pull/13028#issuecomment-1904887153
Thank you for finding this @msfroh! I pushed a commit that should fix the
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
msfroh commented on PR #13028:
URL: https://github.com/apache/lucene/pull/13028#issuecomment-1904540802
Hey -- I was just telling a colleague about this change and he asked about
the synchronization on `initChildrenSiblings`. I talked through the logic in
`computeChildrenSiblings` and reali
stefanvodita commented on code in PR #13028:
URL: https://github.com/apache/lucene/pull/13028#discussion_r1462177725
##
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestTaxonomyIndexArrays.java:
##
@@ -59,4 +64,22 @@ public void testMultiplesOfChunkSize() {
msfroh commented on code in PR #13028:
URL: https://github.com/apache/lucene/pull/13028#discussion_r1462133413
##
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestTaxonomyIndexArrays.java:
##
@@ -59,4 +64,22 @@ public void testMultiplesOfChunkSize() {
stefanvodita opened a new pull request, #13028:
URL: https://github.com/apache/lucene/pull/13028
In #12995, we introduced `allocateChunkedArray`, but had a misaligned
assumption in the constructor for cases where the allocation size is 0. @msfroh
- sorry I missed this check when we refactor
