Re: [PR] Fix NPE when LeafReader return null VectorValues [lucene]

2024-03-20 Thread via GitHub
hossman commented on PR #13162: URL: https://github.com/apache/lucene/pull/13162#issuecomment-2010107912 FWIW: This commit seems to have duplicated `checkField` logic that was previously added in #13105 -- compare `VectorFieldFunction.checkField` with `FloatVectorValues.checkField` and `Byt

Re: [PR] Fix NPE when LeafReader return null VectorValues [lucene]

2024-03-11 Thread via GitHub
benwtrent merged PR #13162: URL: https://github.com/apache/lucene/pull/13162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

Re: [PR] Fix NPE when LeafReader return null VectorValues [lucene]

2024-03-08 Thread via GitHub
bugmakerr commented on code in PR #13162: URL: https://github.com/apache/lucene/pull/13162#discussion_r1517586857 ## lucene/core/src/java/org/apache/lucene/search/FloatVectorSimilarityValuesSource.java: ## @@ -40,6 +40,9 @@ public FloatVectorSimilarityValuesSource(float[] ve

Re: [PR] Fix NPE when LeafReader return null VectorValues [lucene]

2024-03-07 Thread via GitHub
benwtrent commented on code in PR #13162: URL: https://github.com/apache/lucene/pull/13162#discussion_r1516111922 ## lucene/core/src/java/org/apache/lucene/search/FloatVectorSimilarityValuesSource.java: ## @@ -40,6 +40,9 @@ public FloatVectorSimilarityValuesSource(float[] vector

[PR] Fix NPE when LeafReader return null VectorValues [lucene]

2024-03-06 Thread via GitHub
bugmakerr opened a new pull request, #13162: URL: https://github.com/apache/lucene/pull/13162 ### Description `LeafReader#getXXXVectorValues` may return null value. **Reproduction**: ``` public class TestKnnByteVectorQuery extends BaseKnnVectorQueryTestCase { public v