Re: [PR] Fix HistogramCollector to not create zero-count buckets. [lucene]

2025-04-04 Thread via GitHub
jainankitk commented on code in PR #14421: URL: https://github.com/apache/lucene/pull/14421#discussion_r2020439736 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/HistogramCollector.java: ## @@ -279,7 +279,9 @@ public void collect(DocIdStream stream)

Re: [PR] Fix HistogramCollector to not create zero-count buckets. [lucene]

2025-03-31 Thread via GitHub
jpountz commented on PR #14421: URL: https://github.com/apache/lucene/pull/14421#issuecomment-2766465560 I backported to branch_10_2 since this is a bugfix cc @iverase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Fix HistogramCollector to not create zero-count buckets. [lucene]

2025-03-31 Thread via GitHub
jpountz merged PR #14421: URL: https://github.com/apache/lucene/pull/14421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Fix HistogramCollector to not create zero-count buckets. [lucene]

2025-03-29 Thread via GitHub
jpountz commented on code in PR #14421: URL: https://github.com/apache/lucene/pull/14421#discussion_r2019755410 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/HistogramCollector.java: ## @@ -279,7 +279,9 @@ public void collect(DocIdStream stream) thr

Re: [PR] Fix HistogramCollector to not create zero-count buckets. [lucene]

2025-03-28 Thread via GitHub
jainankitk commented on code in PR #14421: URL: https://github.com/apache/lucene/pull/14421#discussion_r2019647007 ## lucene/sandbox/src/test/org/apache/lucene/sandbox/facet/plain/histograms/TestHistogramCollectorManager.java: ## @@ -137,6 +140,23 @@ private void doTestSkipIndex

[PR] Fix HistogramCollector to not create zero-count buckets. [lucene]

2025-03-28 Thread via GitHub
jpountz opened a new pull request, #14421: URL: https://github.com/apache/lucene/pull/14421 If a bucket in the middle of the range doesn't match docs, it would be returned with a count of zero. Better not return it at all. -- This is an automated message from the Apache Git Service. To re