Re: [PR] Fix DirectIOIndexInput seek to not read when position is within buffer [lucene]

2025-03-03 Thread via GitHub
ChrisHegarty merged PR #14320: URL: https://github.com/apache/lucene/pull/14320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

Re: [PR] Fix DirectIOIndexInput seek to not read when position is within buffer [lucene]

2025-03-02 Thread via GitHub
rmuir commented on code in PR #14320: URL: https://github.com/apache/lucene/pull/14320#discussion_r1976613907 ## lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java: ## @@ -373,7 +373,13 @@ public long getFilePointer() { @Override public void seek(

Re: [PR] Fix DirectIOIndexInput seek to not read when position is within buffer [lucene]

2025-03-02 Thread via GitHub
rmuir commented on code in PR #14320: URL: https://github.com/apache/lucene/pull/14320#discussion_r1976613907 ## lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java: ## @@ -373,7 +373,13 @@ public long getFilePointer() { @Override public void seek(

Re: [PR] Fix DirectIOIndexInput seek to not read when position is within buffer [lucene]

2025-03-02 Thread via GitHub
ChrisHegarty commented on PR #14320: URL: https://github.com/apache/lucene/pull/14320#issuecomment-2692699601 I’m going to see if I can write a few small unit tests for this particular scenario. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Fix DirectIOIndexInput seek to not read when position is within buffer [lucene]

2025-03-02 Thread via GitHub
dweiss commented on PR #14320: URL: https://github.com/apache/lucene/pull/14320#issuecomment-2692695298 Good find! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[PR] Fix DirectIOIndexInput seek to not read when position is within buffer [lucene]

2025-03-01 Thread via GitHub
ChrisHegarty opened a new pull request, #14320: URL: https://github.com/apache/lucene/pull/14320 This commit changes DirectIOIndexInput::seek so that it repositions the indexInput's position without a read, when the new position is within the bounds of the current buffer. Prior to th