Re: [PR] Explicitly return needStats flag in TermStates [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #12638: URL: https://github.com/apache/lucene/pull/12638#issuecomment-1880900780 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Explicitly return needStats flag in TermStates [lucene]

2023-10-12 Thread via GitHub
jpountz commented on PR #12638: URL: https://github.com/apache/lucene/pull/12638#issuecomment-1759681148 @yugushihuang Your explanation suggests that a `TermStates` could be created somewhere and then used in a different context. But this is not how it's expected to be used in general, the

Re: [PR] Explicitly return needStats flag in TermStates [lucene]

2023-10-09 Thread via GitHub
gsmiller commented on PR #12638: URL: https://github.com/apache/lucene/pull/12638#issuecomment-1753905354 I'd also be curious to better understand the need here. Is it really about making `#docFreq` and `#totalTermFreq` calls safer/easier for callers somehow? It looks like you'll get `Illeg

Re: [PR] Explicitly return needStats flag in TermStates [lucene]

2023-10-09 Thread via GitHub
yugushihuang commented on PR #12638: URL: https://github.com/apache/lucene/pull/12638#issuecomment-1753389852 Because TermStates can be built with or without the needStats. If in application, we build the TermStates and pass them around. It is worthwhile for the application to check if the

Re: [PR] Explicitly return needStats flag in TermStates [lucene]

2023-10-08 Thread via GitHub
jpountz commented on PR #12638: URL: https://github.com/apache/lucene/pull/12638#issuecomment-1752414836 Can you explain how/when you plan to use this new API? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[PR] Explicitly return needStats flag in TermStates [lucene]

2023-10-08 Thread via GitHub
yugushihuang opened a new pull request, #12638: URL: https://github.com/apache/lucene/pull/12638 ### Description A simple API in TermStates to expose the `needStats` flag. Addresses #12617 # -- This is an automated message from the Apache Git Service. To respond to the m