Re: [PR] Expand scalar quantization with adding half-byte (int4) quantization [lucene]

2024-04-04 Thread via GitHub
benwtrent commented on PR #13197: URL: https://github.com/apache/lucene/pull/13197#issuecomment-2037108804 @jpountz I can add the parameters today and fix the compilation. I think your change is the correct one. -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] Expand scalar quantization with adding half-byte (int4) quantization [lucene]

2024-04-04 Thread via GitHub
jpountz commented on PR #13197: URL: https://github.com/apache/lucene/pull/13197#issuecomment-2036830008 @benwtrent I tried to fix the compilation on luceneutil at https://github.com/mikemccand/luceneutil/commit/027146b05c755c303cac5d95451cc458ed397c51. I could use your help to check if thi

Re: [PR] Expand scalar quantization with adding half-byte (int4) quantization [lucene]

2024-04-02 Thread via GitHub
benwtrent merged PR #13197: URL: https://github.com/apache/lucene/pull/13197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

Re: [PR] Expand scalar quantization with adding half-byte (int4) quantization [lucene]

2024-03-29 Thread via GitHub
benwtrent commented on code in PR #13197: URL: https://github.com/apache/lucene/pull/13197#discussion_r1544695975 ## lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestGenerateBwcIndices.java: ## @@ -82,6 +82,16 @@ public void testCreateSortedIndex() throws IOE

Re: [PR] Expand scalar quantization with adding half-byte (int4) quantization [lucene]

2024-03-27 Thread via GitHub
benwtrent commented on code in PR #13197: URL: https://github.com/apache/lucene/pull/13197#discussion_r1540992353 ## lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/VectorUtilBenchmark.java: ## @@ -36,10 +36,12 @@ public class VectorUtilBenchmark { private byt

Re: [PR] Expand scalar quantization with adding half-byte (int4) quantization [lucene]

2024-03-27 Thread via GitHub
tteofili commented on code in PR #13197: URL: https://github.com/apache/lucene/pull/13197#discussion_r1540836373 ## lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/VectorUtilBenchmark.java: ## @@ -36,10 +36,12 @@ public class VectorUtilBenchmark { private byte

Re: [PR] Expand scalar quantization with adding half-byte (int4) quantization [lucene]

2024-03-27 Thread via GitHub
tteofili commented on PR #13197: URL: https://github.com/apache/lucene/pull/13197#issuecomment-2022409522 I tend to agree on being opinionated on a set of allowed configurations for what concerns the number of bits (4 and 7). Given the speed-space trade-off for packing, I think it's usefu