benwtrent commented on PR #13197:
URL: https://github.com/apache/lucene/pull/13197#issuecomment-2037108804
@jpountz I can add the parameters today and fix the compilation. I think
your change is the correct one.
--
This is an automated message from the Apache Git Service.
To respond to th
jpountz commented on PR #13197:
URL: https://github.com/apache/lucene/pull/13197#issuecomment-2036830008
@benwtrent I tried to fix the compilation on luceneutil at
https://github.com/mikemccand/luceneutil/commit/027146b05c755c303cac5d95451cc458ed397c51.
I could use your help to check if thi
benwtrent merged PR #13197:
URL: https://github.com/apache/lucene/pull/13197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
benwtrent commented on code in PR #13197:
URL: https://github.com/apache/lucene/pull/13197#discussion_r1544695975
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestGenerateBwcIndices.java:
##
@@ -82,6 +82,16 @@ public void testCreateSortedIndex() throws IOE
benwtrent commented on code in PR #13197:
URL: https://github.com/apache/lucene/pull/13197#discussion_r1540992353
##
lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/VectorUtilBenchmark.java:
##
@@ -36,10 +36,12 @@ public class VectorUtilBenchmark {
private byt
tteofili commented on code in PR #13197:
URL: https://github.com/apache/lucene/pull/13197#discussion_r1540836373
##
lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/VectorUtilBenchmark.java:
##
@@ -36,10 +36,12 @@ public class VectorUtilBenchmark {
private byte
tteofili commented on PR #13197:
URL: https://github.com/apache/lucene/pull/13197#issuecomment-2022409522
I tend to agree on being opinionated on a set of allowed configurations for
what concerns the number of bits (4 and 7).
Given the speed-space trade-off for packing, I think it's usefu