jpountz closed pull request #14280: ExceptionInInitializerError in ScorerUtil
URL: https://github.com/apache/lucene/pull/14280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
jpountz commented on PR #14280:
URL: https://github.com/apache/lucene/pull/14280#issuecomment-2689123306
I merged my other PR, which should supersede this one. Closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
jpountz commented on PR #14280:
URL: https://github.com/apache/lucene/pull/14280#issuecomment-2688597916
This sounded like a good idea so I applied it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
uschindler commented on PR #14280:
URL: https://github.com/apache/lucene/pull/14280#issuecomment-2688112479
But this is fine. We currently only have shared secrets for tests.
Making that class public does not hurt.
--
This is an automated message from the Apache Git Service.
To respond
uschindler commented on PR #14280:
URL: https://github.com/apache/lucene/pull/14280#issuecomment-2688104449
This is better. But best would be to add a getter for the class in our
internal package (like we do for other stuff). The usual SharedSecrets approach.
--
This is an automated messa
jpountz commented on PR #14280:
URL: https://github.com/apache/lucene/pull/14280#issuecomment-2688043954
It looks like another problem with the current code is that codec
randomization may randomly run before this block of code, making it unreliable
when running tests. I opened #14306 as an
uschindler commented on PR #14280:
URL: https://github.com/apache/lucene/pull/14280#issuecomment-2687575659
Generally the issue here could be solved using this JEP which is long
awaited: https://openjdk.org/jeps/8209964
--
This is an automated message from the Apache Git Service.
To respo
uschindler commented on PR #14280:
URL: https://github.com/apache/lucene/pull/14280#issuecomment-2687564614
I get crazy when I see this code (before and after). 😜
In general I would rewrite that in a different way to not use a test index
to initialize the code. Can't we figure out wha
jpountz commented on PR #14280:
URL: https://github.com/apache/lucene/pull/14280#issuecomment-2687278510
One concern I have with this change is that this code now runs as part of
evaluating a query, when users care about query latency.
@uschindler You usually have informed opinions on
imario42 opened a new pull request, #14280:
URL: https://github.com/apache/lucene/pull/14280
lazy initialize the ScorerUtil DEFAULT_IMPACTS_ENUM_CLASS to prevent
initialization issues with this class if the thread gets interrupted.
### Description
The ScorerUtils fails to initi
10 matches
Mail list logo
