Re: [PR] Disable the query cache by default. [lucene]

2025-04-02 Thread via GitHub
jpountz merged PR #14187: URL: https://github.com/apache/lucene/pull/14187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Disable the query cache by default. [lucene]

2025-03-31 Thread via GitHub
msfroh commented on code in PR #14187: URL: https://github.com/apache/lucene/pull/14187#discussion_r2021571472 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -77,7 +77,8 @@ public class IndexSearcher { static int maxClauseCount = 1024; - privat

Re: [PR] Disable the query cache by default. [lucene]

2025-03-27 Thread via GitHub
github-actions[bot] commented on PR #14187: URL: https://github.com/apache/lucene/pull/14187#issuecomment-2759877242 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Disable the query cache by default. [lucene]

2025-03-13 Thread via GitHub
jpountz commented on code in PR #14187: URL: https://github.com/apache/lucene/pull/14187#discussion_r1993476471 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -77,7 +77,8 @@ public class IndexSearcher { static int maxClauseCount = 1024; - priva

Re: [PR] Disable the query cache by default. [lucene]

2025-03-12 Thread via GitHub
msfroh commented on code in PR #14187: URL: https://github.com/apache/lucene/pull/14187#discussion_r1992514802 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -77,7 +77,8 @@ public class IndexSearcher { static int maxClauseCount = 1024; - privat

Re: [PR] Disable the query cache by default. [lucene]

2025-03-12 Thread via GitHub
github-actions[bot] commented on PR #14187: URL: https://github.com/apache/lucene/pull/14187#issuecomment-2719430102 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Disable the query cache by default. [lucene]

2025-02-26 Thread via GitHub
sgup432 commented on PR #14187: URL: https://github.com/apache/lucene/pull/14187#issuecomment-2686276505 >I agree with the judgment, but maybe this just indicates we need to improve the cache! Agree here that we need to improve the cache itself. I had opened an issue [here](https://g

Re: [PR] Disable the query cache by default. [lucene]

2025-02-24 Thread via GitHub
jpountz commented on PR #14187: URL: https://github.com/apache/lucene/pull/14187#issuecomment-2679832873 For the record, another downside of the query cache: the fact that it caches per segment doesn't play nicely with intra segment concurrency. E.g. if you have a single large segment that

Re: [PR] Disable the query cache by default. [lucene]

2025-02-17 Thread via GitHub
github-actions[bot] commented on PR #14187: URL: https://github.com/apache/lucene/pull/14187#issuecomment-2664271825 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Disable the query cache by default. [lucene]

2025-02-03 Thread via GitHub
mikemccand commented on code in PR #14187: URL: https://github.com/apache/lucene/pull/14187#discussion_r1939310871 ## lucene/CHANGES.txt: ## @@ -30,6 +30,10 @@ Bug Fixes * GITHUB#14075: Remove duplicate and add missing entry on brazilian portuguese stopwords list. (Arthur Ca

Re: [PR] Disable the query cache by default. [lucene]

2025-01-30 Thread via GitHub
msokolov commented on PR #14187: URL: https://github.com/apache/lucene/pull/14187#issuecomment-2625649749 I agree with the judgment, but maybe this just indicates we need to improve the cache! Still, until we can figure out how to do so, +1 to disable by default -- This is an automated me

[PR] Disable the query cache by default. [lucene]

2025-01-30 Thread via GitHub
jpountz opened a new pull request, #14187: URL: https://github.com/apache/lucene/pull/14187 The query cache trades heap for faster queries. Given all the progress that has been made on making uncached queries faster (`IndexOrDocValuesQuery`, bitset encoding of blocks of postings, etc.), it'