Re: [PR] Disable sort optimization when tracking all docs [lucene]

2025-04-11 Thread via GitHub
vibrantvarun commented on code in PR #14395: URL: https://github.com/apache/lucene/pull/14395#discussion_r2040138727 ## lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java: ## @@ -59,6 +59,13 @@ private abstract class TopFieldLeafCollector implements LeafCollec

Re: [PR] Disable sort optimization when tracking all docs [lucene]

2025-04-11 Thread via GitHub
vibrantvarun commented on PR #14395: URL: https://github.com/apache/lucene/pull/14395#issuecomment-2797801131 Overall code looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Disable sort optimization when tracking all docs [lucene]

2025-04-08 Thread via GitHub
github-actions[bot] commented on PR #14395: URL: https://github.com/apache/lucene/pull/14395#issuecomment-2787928763 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Disable sort optimization when tracking all docs [lucene]

2025-03-25 Thread via GitHub
bugmakerr commented on PR #14395: URL: https://github.com/apache/lucene/pull/14395#issuecomment-2750983066 > The change looks correct to me. With recent changes to allow clauses that match all docs to remove themselves from a conjunction, it should be possible to achieve something simil

Re: [PR] Disable sort optimization when tracking all docs [lucene]

2025-03-24 Thread via GitHub
jpountz commented on PR #14395: URL: https://github.com/apache/lucene/pull/14395#issuecomment-2748864218 The change looks correct to me. With recent changes to allow clauses that match all docs to remove themselves from a conjunction, it should be possible to achieve something similar by im

[PR] Disable sort optimization when tracking all docs [lucene]

2025-03-24 Thread via GitHub
bugmakerr opened a new pull request, #14395: URL: https://github.com/apache/lucene/pull/14395 ### Description When `totalHitsThreshold` is greater than or equal to number of docs, we can disable the sort optimization. -- This is an automated message from the Apache Git