Re: [PR] DeletedTerms#clear should reset ByteBlockPool [lucene]

2023-10-09 Thread via GitHub
gf2121 merged PR #12630: URL: https://github.com/apache/lucene/pull/12630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] DeletedTerms#clear should reset ByteBlockPool [lucene]

2023-10-09 Thread via GitHub
gf2121 commented on code in PR #12630: URL: https://github.com/apache/lucene/pull/12630#discussion_r1350277816 ## lucene/core/src/test/org/apache/lucene/index/TestBufferedUpdates.java: ## @@ -61,10 +61,10 @@ public void testRamBytesUsed() { public void testDeletedTerms() {

Re: [PR] DeletedTerms#clear should reset ByteBlockPool [lucene]

2023-10-09 Thread via GitHub
gf2121 commented on PR #12630: URL: https://github.com/apache/lucene/pull/12630#issuecomment-1752936864 > Just to confirm: the previous PR was not released/included in 9.8.0 right? So users are not hitting this memory leak when using the 9.8.0 release. Yes, the previous PR is not incl

Re: [PR] DeletedTerms#clear should reset ByteBlockPool [lucene]

2023-10-09 Thread via GitHub
jpountz commented on PR #12630: URL: https://github.com/apache/lucene/pull/12630#issuecomment-1752884136 wow good catch. Out of curiosity, how did you catch it? Are you running snapshot Lucene builds in production? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] DeletedTerms#clear should reset ByteBlockPool [lucene]

2023-10-09 Thread via GitHub
mikemccand commented on code in PR #12630: URL: https://github.com/apache/lucene/pull/12630#discussion_r1350170058 ## lucene/core/src/test/org/apache/lucene/index/TestBufferedUpdates.java: ## @@ -61,10 +61,10 @@ public void testRamBytesUsed() { public void testDeletedTerms()

[PR] DeletedTerms#clear should reset ByteBlockPool [lucene]

2023-10-06 Thread via GitHub
gf2121 opened a new pull request, #12630: URL: https://github.com/apache/lucene/pull/12630 ### Description This is a bug left by #12573. As we are using a common `ByteBlockPool` across all `BytesRefHash`, the map clear won't help release the memory held by `ByteBlockPool` and the poo