Re: [PR] Completion FSTs to be loaded off-heap by default [lucene]

2025-04-05 Thread via GitHub
javanna commented on code in PR #14364: URL: https://github.com/apache/lucene/pull/14364#discussion_r2000872434 ## lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java: ## @@ -951,7 +951,16 @@ static IndexWriterConfig iwcWithSuggestField(Analyz

Re: [PR] Completion FSTs to be loaded off-heap by default [lucene]

2025-03-17 Thread via GitHub
jpountz commented on code in PR #14364: URL: https://github.com/apache/lucene/pull/14364#discussion_r1999714466 ## lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java: ## @@ -951,7 +951,16 @@ static IndexWriterConfig iwcWithSuggestField(Analyz

Re: [PR] Completion FSTs to be loaded off-heap by default [lucene]

2025-03-17 Thread via GitHub
javanna commented on code in PR #14364: URL: https://github.com/apache/lucene/pull/14364#discussion_r1999421774 ## lucene/suggest/src/java/org/apache/lucene/search/suggest/document/Completion101PostingsFormat.java: ## @@ -25,17 +25,9 @@ * @lucene.experimental */ public clas

Re: [PR] Completion FSTs to be loaded off-heap by default [lucene]

2025-03-17 Thread via GitHub
javanna commented on code in PR #14364: URL: https://github.com/apache/lucene/pull/14364#discussion_r1999422163 ## lucene/suggest/src/java/org/apache/lucene/search/suggest/document/CompletionPostingsFormat.java: ## @@ -122,11 +122,6 @@ public enum FSTLoadMode { private fina

[PR] Completion FSTs to be loaded off-heap by default [lucene]

2025-03-17 Thread via GitHub
javanna opened a new pull request, #14364: URL: https://github.com/apache/lucene/pull/14364 All the existing completion postings format load their FSTs on-heap. It is possible to customize that behaviour by mainintaing a custom postings format that override the fst load mode. TestSug