vsop-479 closed pull request #13928: Change StringHelper from abstract to final.
URL: https://github.com/apache/lucene/pull/13928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
vsop-479 commented on PR #13928:
URL: https://github.com/apache/lucene/pull/13928#issuecomment-2423382437
> it's not necessary.
I will close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
uschindler commented on PR #13928:
URL: https://github.com/apache/lucene/pull/13928#issuecomment-2422935859
If you really want to change it, make it final. But it's not necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
vsop-479 commented on PR #13928:
URL: https://github.com/apache/lucene/pull/13928#issuecomment-2422239762
Thanks @uschindler — Do you think it is necessary that just remove the
abstract modifier?
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
uschindler commented on PR #13928:
URL: https://github.com/apache/lucene/pull/13928#issuecomment-2422157253
I am not sure if this change is needed at all. There are multiple patterns
to make static only classes. The most important one is to add a private ctor.
The final or not doesn't reall
vsop-479 commented on PR #13928:
URL: https://github.com/apache/lucene/pull/13928#issuecomment-2421959479
I moved the private constructor to the beginning place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
vsop-479 commented on PR #13928:
URL: https://github.com/apache/lucene/pull/13928#issuecomment-2421931690
> Can you add a private constructor then?
There already is a private constructor in it (line 66).
--
This is an automated message from the Apache Git Service.
To respond to the
jpountz commented on PR #13928:
URL: https://github.com/apache/lucene/pull/13928#issuecomment-2421863526
I believe that the abstract modifier aimed at preventing instantiation. Can
you add a private constructor then?
--
This is an automated message from the Apache Git Service.
To respond
vsop-479 opened a new pull request, #13928:
URL: https://github.com/apache/lucene/pull/13928
### Description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
