Re: [PR] CandidateMatcher public matching functions [lucene]

2024-08-07 Thread via GitHub
romseygeek commented on PR #13632: URL: https://github.com/apache/lucene/pull/13632#issuecomment-2273613663 Thanks @bjacobowitz! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] CandidateMatcher public matching functions [lucene]

2024-08-07 Thread via GitHub
romseygeek merged PR #13632: URL: https://github.com/apache/lucene/pull/13632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

Re: [PR] CandidateMatcher public matching functions [lucene]

2024-08-06 Thread via GitHub
romseygeek commented on code in PR #13632: URL: https://github.com/apache/lucene/pull/13632#discussion_r1705166098 ## lucene/monitor/src/test/org/apache/lucene/monitor/outsidepackage/TestCandidateMatcherVisibility.java: ## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Softwar

[PR] CandidateMatcher public matching functions [lucene]

2024-08-05 Thread via GitHub
bjacobowitz opened a new pull request, #13632: URL: https://github.com/apache/lucene/pull/13632 ### Description In `CandidateMatcher`, increase visibility of `matchQuery()` (from protected), `finish()` and `reportError()` (from package-private) to public, so that a `CandidateMatcher`