dweiss commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1971275304
> Uwe "merging in microseconds" with TortoiseSVN...
Not surprised. If it can be done at all, Uwe is probably capable of it.
--
This is an automated message from the Apache Git Ser
rmuir commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1971039258
I'm just picking fun, there's an old joke about Uwe "merging in
microseconds" with TortoiseSVN...
--
This is an automated message from the Apache Git Service.
To respond to the message,
dweiss commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1971009568
I think you could recover by reverting the wrong merge commit(s), then reset
Chris's branch to the state you want. It's all a graph of states and labels -
you can restore anything you wan
uschindler commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1970981602
Nah it wasn't because of rebasing or anything like that. I just started a
new branch but forget to switch to it. I then merged Chris' changes in.
I corrected that later, but lef
rmuir commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1970952621
> Closing, the DIFF view in this PR is now broken, sorry. No idea how to
tell github to use the original branch.
This is why I never rebase/force push, and only use merge :)
uschindler commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1970904960
Sorry, I f*cked up the whole branch and this PR because i pushed the wrong
branch to main.
I will just merge it manually and close the PR. Sorry for this. You should
not work w
uschindler commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1970919007
merged this as 8f17f23acf5c54baaea1361315d23f986f13c0f0
Closing, the DIFF view in this PR is now broken, sorry. No idea how to tell
github to use the original branch.
--
Thi
uschindler closed pull request #12753: Bump minimum required Java version to 21
URL: https://github.com/apache/lucene/pull/12753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dweiss commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1970754253
I allowed myself to merge the main branch and update JVM list in
run-nightly-smoketester.yml.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
uschindler commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1970680398
I have a branch already with the MRJAR cleanup and ByteBufferIndexInput
removal. I also found a bug in 9.x in the NRTSuggester which wasn't aber to
detect off-heap correctly (it just
uschindler commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1970065350
> I have no time to do this now, but we should at least one time check that
Emma works with Java 21 class files:
>
> ```shell
> $ ./gradlew test -Ptests.coverage=true
> ``
uschindler commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1970050803
I have no time to do this now, but we should at least one time check that
Emma works with Java 21:
```sh
$ ./gradlew test -Ptests.coverage=true
```
--
This is an automated
uschindler commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1970043318
Policeman Jenkins also updated to use Java 21 as base JDK and randomize this
or later versions/bitness/GC options with RUNTIME_JAVA_HOME
--
This is an automated message from the Apa
uschindler commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1970023486
ASF Jenkins was updated to run all Jobs with Java 21. Currently untested is
EMMA Coverage builds, we should maybe test this here, too. It could be that we
may need to update Emma depe
uschindler commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1970011748
Just give me a one hour pre-announcenent before merging this PR, so I can
reconfigure Jenkins servers.
It's too late today, but I will do this tomorrow morning.
--
This is an aut
uschindler commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1969985276
The vote has passed. I think it's ready to merge.
I have time tomorrow and would like to cleanup the MR-JAR code and remove
the legacy ByteBufferIndexInput.
--
This is an aut
rmuir commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1966604919
Thank you for merging!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
uschindler commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1966464023
Hi @rmuir @stefanvodita: I merged main branch into this and resolved the
conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
uschindler commented on code in PR #12753:
URL: https://github.com/apache/lucene/pull/12753#discussion_r1501837680
##
gradle/documentation/render-javadoc.gradle:
##
@@ -423,7 +423,7 @@ class RenderJavadocTask extends DefaultTask {
opts << [ '-linkoffline', url, dir ]
uschindler commented on code in PR #12753:
URL: https://github.com/apache/lucene/pull/12753#discussion_r1501833603
##
gradle/documentation/render-javadoc.gradle:
##
@@ -423,7 +423,7 @@ class RenderJavadocTask extends DefaultTask {
opts << [ '-linkoffline', url, dir ]
rmuir commented on code in PR #12753:
URL: https://github.com/apache/lucene/pull/12753#discussion_r1501828782
##
gradle/documentation/render-javadoc.gradle:
##
@@ -423,7 +423,7 @@ class RenderJavadocTask extends DefaultTask {
opts << [ '-linkoffline', url, dir ]
}
uschindler commented on code in PR #12753:
URL: https://github.com/apache/lucene/pull/12753#discussion_r1501798373
##
gradle/documentation/render-javadoc.gradle:
##
@@ -423,7 +423,7 @@ class RenderJavadocTask extends DefaultTask {
opts << [ '-linkoffline', url, dir ]
uschindler commented on code in PR #12753:
URL: https://github.com/apache/lucene/pull/12753#discussion_r1501797823
##
gradle/documentation/render-javadoc.gradle:
##
@@ -423,7 +423,7 @@ class RenderJavadocTask extends DefaultTask {
opts << [ '-linkoffline', url, dir ]
uschindler commented on code in PR #12753:
URL: https://github.com/apache/lucene/pull/12753#discussion_r1501797823
##
gradle/documentation/render-javadoc.gradle:
##
@@ -423,7 +423,7 @@ class RenderJavadocTask extends DefaultTask {
opts << [ '-linkoffline', url, dir ]
rmuir commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1962700020
I fixed those scripts: it was a straight replacement of `17` to `21`. Will
not be touching other logic here as I don't wish to duplicate work when this
file is being cleaned up in another
ChrisHegarty commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1961692584
> When we merge this we should remove or migrate the already existing Java
17 entry in lucene 10.0.0 section of changes.txt.
Good point. Done.
--
This is an automated messa
26 matches
Mail list logo