Re: [PR] Avoid object construct when linear search [lucene]

gf2121 commented on code in PR #12692: URL: https://github.com/apache/lucene/pull/12692#discussion_r1365835239 ## lucene/core/src/java/org/apache/lucene/util/fst/FST.java: ## @@ -1081,22 +1085,30 @@ public Arc findTargetArc(int labelToMatch, Arc follow, Arc arc, BytesRe }

Re: [PR] Avoid object construct when linear search [lucene]

mikemccand commented on code in PR #12692: URL: https://github.com/apache/lucene/pull/12692#discussion_r1365740888 ## lucene/core/src/java/org/apache/lucene/util/fst/FST.java: ## @@ -1081,22 +1085,30 @@ public Arc findTargetArc(int labelToMatch, Arc follow, Arc arc, BytesRe

Re: [PR] Avoid object construct when linear search [lucene]

gf2121 commented on code in PR #12692: URL: https://github.com/apache/lucene/pull/12692#discussion_r1364900678 ## lucene/core/src/java/org/apache/lucene/util/fst/FST.java: ## @@ -1081,22 +1085,30 @@ public Arc findTargetArc(int labelToMatch, Arc follow, Arc arc, BytesRe }

Re: [PR] Avoid object construct when linear search [lucene]

mikemccand commented on code in PR #12692: URL: https://github.com/apache/lucene/pull/12692#discussion_r1364130745 ## lucene/core/src/java/org/apache/lucene/util/fst/FST.java: ## @@ -1081,22 +1085,30 @@ public Arc findTargetArc(int labelToMatch, Arc follow, Arc arc, BytesRe

Re: [PR] Avoid object construct when linear search [lucene]

gf2121 commented on code in PR #12692: URL: https://github.com/apache/lucene/pull/12692#discussion_r1363924060 ## lucene/core/src/java/org/apache/lucene/util/fst/FST.java: ## @@ -1081,22 +1085,30 @@ public Arc findTargetArc(int labelToMatch, Arc follow, Arc arc, BytesRe }

Re: [PR] Avoid object construct when linear search [lucene]

mikemccand commented on code in PR #12692: URL: https://github.com/apache/lucene/pull/12692#discussion_r1363842558 ## lucene/core/src/java/org/apache/lucene/util/fst/FST.java: ## @@ -1081,22 +1085,30 @@ public Arc findTargetArc(int labelToMatch, Arc follow, Arc arc, BytesRe

Re: [PR] Avoid object construct when linear search [lucene]

gf2121 commented on PR #12692: URL: https://github.com/apache/lucene/pull/12692#issuecomment-1768310698 Result on wikimediumall (nothing changed obviously) : ``` TaskQPS baseline StdDevQPS my_modified_version StdDevPct diff p-value

[PR] Avoid object construct when linear search [lucene]

gf2121 opened a new pull request, #12692: URL: https://github.com/apache/lucene/pull/12692 ### Description This PR resolves a todo left in `FST` that we construct some useless objects during linear search. This is also an effort that tries to avoid `Outputs#read` as we have more outp