Re: [PR] Align instanceof check with type cast [lucene]

2024-01-30 Thread via GitHub
sabi0 commented on PR #13039: URL: https://github.com/apache/lucene/pull/13039#issuecomment-1916580962 Thank you. I will make sure the new PRs have them out of the box. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Align instanceof check with type cast [lucene]

2024-01-30 Thread via GitHub
uschindler commented on PR #13039: URL: https://github.com/apache/lucene/pull/13039#issuecomment-1916576302 I added the changes entry to the existing one for you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Align instanceof check with type cast [lucene]

2024-01-30 Thread via GitHub
uschindler merged PR #13039: URL: https://github.com/apache/lucene/pull/13039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

Re: [PR] Align instanceof check with type cast [lucene]

2024-01-30 Thread via GitHub
sabi0 commented on code in PR #13039: URL: https://github.com/apache/lucene/pull/13039#discussion_r1470768641 ## lucene/core/src/java/org/apache/lucene/analysis/tokenattributes/PayloadAttributeImpl.java: ## @@ -62,8 +62,7 @@ public boolean equals(Object other) { return tr

Re: [PR] Align instanceof check with type cast [lucene]

2024-01-29 Thread via GitHub
uschindler commented on code in PR #13039: URL: https://github.com/apache/lucene/pull/13039#discussion_r1470388288 ## lucene/core/src/java/org/apache/lucene/analysis/tokenattributes/PayloadAttributeImpl.java: ## @@ -62,8 +62,7 @@ public boolean equals(Object other) { retu

Re: [PR] Align instanceof check with type cast [lucene]

2024-01-29 Thread via GitHub
uschindler commented on code in PR #13039: URL: https://github.com/apache/lucene/pull/13039#discussion_r1470387185 ## lucene/core/src/java/org/apache/lucene/analysis/tokenattributes/PayloadAttributeImpl.java: ## @@ -62,8 +62,7 @@ public boolean equals(Object other) { retu

Re: [PR] Align instanceof check with type cast [lucene]

2024-01-29 Thread via GitHub
sabi0 commented on code in PR #13039: URL: https://github.com/apache/lucene/pull/13039#discussion_r1470102508 ## lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/processors/AnalyzerQueryNodeProcessor.java: ## @@ -107,10 +105,9 @@ public QueryNode proce