Re: [PR] Adding optional queryDescription String to AbstractKnnVectorQuery [lucene]

2023-11-16 Thread via GitHub
slow-J commented on PR #12816: URL: https://github.com/apache/lucene/pull/12816#issuecomment-1815014722 Thanks for the suggestion @jpountz! I'll add a `HumanReadableQuery` and revert the current changes. I think it would be quite similar to the `AssertingQuery`. -- This is an automated m

Re: [PR] Adding optional queryDescription String to AbstractKnnVectorQuery [lucene]

2023-11-16 Thread via GitHub
benwtrent commented on PR #12816: URL: https://github.com/apache/lucene/pull/12816#issuecomment-1814712957 I much prefer @jpountz idea. This additional field is purely for debugging purposes. A `DebugQuery` or `HumanReadableQuery` does seem like a good idea. -- This is an automated messag

Re: [PR] Adding optional queryDescription String to AbstractKnnVectorQuery [lucene]

2023-11-16 Thread via GitHub
jpountz commented on PR #12816: URL: https://github.com/apache/lucene/pull/12816#issuecomment-1814699360 I'd rather like not to touch these queries, and introduce a brand new query that rewrites to a `Knn(Byte|Float)VectorQuery` and may add a description string. Something like `HumanReadabl

[PR] Adding optional queryDescription String to AbstractKnnVectorQuery [lucene]

2023-11-16 Thread via GitHub
slow-J opened a new pull request, #12816: URL: https://github.com/apache/lucene/pull/12816 We use this only in KnnByte/FloatVectorQuery toString method so the benchmarker can disambiguate between different KnnFloatVectorQuery/KnnByteVectorQuery queries. Closes #12487 -- This i