kaivalnp commented on PR #13285:
URL: https://github.com/apache/lucene/pull/13285#issuecomment-2270443993
Thank you @vigyasharma!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
vigyasharma merged PR #13285:
URL: https://github.com/apache/lucene/pull/13285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene
vigyasharma commented on code in PR #13285:
URL: https://github.com/apache/lucene/pull/13285#discussion_r1704745053
##
lucene/core/src/test/org/apache/lucene/search/BaseVectorSimilarityQueryTestCase.java:
##
@@ -475,6 +479,62 @@ public void testApproximate() throws IOException {
kaivalnp commented on PR #13285:
URL: https://github.com/apache/lucene/pull/13285#issuecomment-2268639204
There was a conflict in `CHANGES.txt` after a recent commit, merged from
`main` and resolved that
@vigyasharma I've tried to address all open comments, please let me know if
somethin
kaivalnp commented on code in PR #13285:
URL: https://github.com/apache/lucene/pull/13285#discussion_r1697415078
##
lucene/core/src/java/org/apache/lucene/search/AbstractVectorSimilarityQuery.java:
##
@@ -143,27 +156,23 @@ protected boolean match(int doc) {
}
kaivalnp commented on code in PR #13285:
URL: https://github.com/apache/lucene/pull/13285#discussion_r1697413263
##
lucene/core/src/java/org/apache/lucene/search/AbstractVectorSimilarityQuery.java:
##
@@ -103,16 +114,18 @@ public Explanation explain(LeafReaderContext context, in
vigyasharma commented on code in PR #13285:
URL: https://github.com/apache/lucene/pull/13285#discussion_r1691961312
##
lucene/core/src/java/org/apache/lucene/search/AbstractVectorSimilarityQuery.java:
##
@@ -143,27 +156,23 @@ protected boolean match(int doc) {
}
dungba88 commented on code in PR #13285:
URL: https://github.com/apache/lucene/pull/13285#discussion_r1689608050
##
lucene/core/src/java/org/apache/lucene/search/AbstractVectorSimilarityQuery.java:
##
@@ -143,27 +156,23 @@ protected boolean match(int doc) {
}
kaivalnp commented on code in PR #13285:
URL: https://github.com/apache/lucene/pull/13285#discussion_r1689584585
##
lucene/core/src/java/org/apache/lucene/search/AbstractVectorSimilarityQuery.java:
##
@@ -103,16 +114,18 @@ public Explanation explain(LeafReaderContext context, in
kaivalnp commented on code in PR #13285:
URL: https://github.com/apache/lucene/pull/13285#discussion_r1689579251
##
lucene/core/src/java/org/apache/lucene/search/AbstractVectorSimilarityQuery.java:
##
@@ -143,27 +156,23 @@ protected boolean match(int doc) {
}
dungba88 commented on code in PR #13285:
URL: https://github.com/apache/lucene/pull/13285#discussion_r1689296027
##
lucene/core/src/java/org/apache/lucene/search/AbstractVectorSimilarityQuery.java:
##
@@ -103,16 +114,18 @@ public Explanation explain(LeafReaderContext context, in
kaivalnp commented on PR #13285:
URL: https://github.com/apache/lucene/pull/13285#issuecomment-2158288293
Summary of latest changes:
1. Resolved merge conflicts
2. Moved `CHANGES.txt` entry from 9.11 -> 9.12 since the prior is now
released
3. `#Scorer` is now `final` and not overrid
github-actions[bot] commented on PR #13285:
URL: https://github.com/apache/lucene/pull/13285#issuecomment-2134164108
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
kaivalnp commented on code in PR #13285:
URL: https://github.com/apache/lucene/pull/13285#discussion_r1599150976
##
lucene/core/src/java/org/apache/lucene/search/AbstractVectorSimilarityQuery.java:
##
@@ -105,13 +116,16 @@ public Scorer scorer(LeafReaderContext context) throws
kaivalnp commented on code in PR #13285:
URL: https://github.com/apache/lucene/pull/13285#discussion_r1599151876
##
lucene/core/src/java/org/apache/lucene/search/AbstractVectorSimilarityQuery.java:
##
@@ -144,22 +158,22 @@ protected boolean match(int doc) {
}
kaivalnp commented on code in PR #13285:
URL: https://github.com/apache/lucene/pull/13285#discussion_r1599150976
##
lucene/core/src/java/org/apache/lucene/search/AbstractVectorSimilarityQuery.java:
##
@@ -105,13 +116,16 @@ public Scorer scorer(LeafReaderContext context) throws
msokolov commented on code in PR #13285:
URL: https://github.com/apache/lucene/pull/13285#discussion_r1599136370
##
lucene/core/src/java/org/apache/lucene/search/AbstractVectorSimilarityQuery.java:
##
@@ -105,13 +116,16 @@ public Scorer scorer(LeafReaderContext context) throws
kaivalnp commented on PR #13285:
URL: https://github.com/apache/lucene/pull/13285#issuecomment-2107012946
Hi @benwtrent @vigyasharma could you help review this? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
kaivalnp commented on PR #13285:
URL: https://github.com/apache/lucene/pull/13285#issuecomment-2103463681
Saw some merge conflicts after a recent commit and resolved those..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kaivalnp commented on PR #13285:
URL: https://github.com/apache/lucene/pull/13285#issuecomment-2075846511
Thanks @benwtrent! Added an entry now..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
benwtrent commented on PR #13285:
URL: https://github.com/apache/lucene/pull/13285#issuecomment-2075661472
@kaivalnp could you update CHANGES as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
benwtrent commented on PR #13285:
URL: https://github.com/apache/lucene/pull/13285#issuecomment-2075660880
This seems sane to me.
@vigyasharma what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
github-actions[bot] commented on PR #13285:
URL: https://github.com/apache/lucene/pull/13285#issuecomment-2073696066
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
kaivalnp opened a new pull request, #13285:
URL: https://github.com/apache/lucene/pull/13285
### Description
Along similar lines of #13202, adding timeout support for
[`AbstractVectorSimilarityQuery`](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/se
24 matches
Mail list logo
