Re: [PR] Add test for parsing brackets in range queries [lucene]

2024-05-27 Thread via GitHub
dweiss commented on PR #13323: URL: https://github.com/apache/lucene/pull/13323#issuecomment-2133921546 Apologies for the delay, @benchaplin - I've merged this test into the main branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Add test for parsing brackets in range queries [lucene]

2024-05-27 Thread via GitHub
dweiss merged PR #13323: URL: https://github.com/apache/lucene/pull/13323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Add test for parsing brackets in range queries [lucene]

2024-05-23 Thread via GitHub
benchaplin commented on PR #13323: URL: https://github.com/apache/lucene/pull/13323#issuecomment-2127990572 Thanks for the advice @dweiss, I will play around with some test cases for this fix. In the meantime, I think we can merge this and I will open another PR with the grammar changes if

Re: [PR] Add test for parsing brackets in range queries [lucene]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #13323: URL: https://github.com/apache/lucene/pull/13323#issuecomment-2111363928 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Add test for parsing brackets in range queries [lucene]

2024-04-29 Thread via GitHub
dweiss commented on PR #13323: URL: https://github.com/apache/lucene/pull/13323#issuecomment-2084510167 The joys of escaping... Never easy (hello, Windows command-line users...). You may want to add a randomized test that constructs those terms using a mix of characters and "allowed" escape

Re: [PR] Add test for parsing brackets in range queries [lucene]

2024-04-29 Thread via GitHub
benchaplin commented on PR #13323: URL: https://github.com/apache/lucene/pull/13323#issuecomment-2083680863 I was thinking a fix like this could work: ```java | ``` simply allowing the range term to continue parsing through an escaped space or closing bracket. "Br

Re: [PR] Add test for parsing brackets in range queries [lucene]

2024-04-25 Thread via GitHub
dweiss commented on PR #13323: URL: https://github.com/apache/lucene/pull/13323#issuecomment-2078091483 > Any thoughts on whether queryParser.parse( "[ a\\[i\\] TO b\\[i\\] ]" ); should work? I did play around with updating the grammar, it should be possible but I need to think more about h

[PR] Add test for parsing brackets in range queries [lucene]

2024-04-24 Thread via GitHub
benchaplin opened a new pull request, #13323: URL: https://github.com/apache/lucene/pull/13323 ### Description I've added some unit tests to protect/display the QueryParser's ability to parse brackets in range query terms when in quotes. [This issue](https://github.com/apache/l