Re: [PR] Add support for running ast-grep rules [lucene]

2025-06-18 Thread via GitHub
dweiss commented on PR #14808: URL: https://github.com/apache/lucene/pull/14808#issuecomment-2985638437 Sorry for not waiting, I wanted to proceed. Please open a new issue with those rules. This one looks very neat indeed - we can even force it to run prior to javac. It's a C based parser f

Re: [PR] Add support for running ast-grep rules [lucene]

2025-06-18 Thread via GitHub
rmuir commented on PR #14808: URL: https://github.com/apache/lucene/pull/14808#issuecomment-2985574748 Thank you @dweiss, I was just slow, was testing it out. I set the property locally, and added rule and test: ```yaml --- # yaml-language-server: $schema=https://raw.githubusercont

Re: [PR] Add support for running ast-grep rules [lucene]

2025-06-18 Thread via GitHub
dweiss merged PR #14808: URL: https://github.com/apache/lucene/pull/14808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Add support for running ast-grep rules [lucene]

2025-06-18 Thread via GitHub
dweiss commented on PR #14808: URL: https://github.com/apache/lucene/pull/14808#issuecomment-2985547456 I'll allow myself to merge this in without a review. I don't think anybody will object (but if anybody does, shout out). -- This is an automated message from the Apache Git Service. To

Re: [PR] Add support for running ast-grep rules [lucene]

2025-06-18 Thread via GitHub
github-actions[bot] commented on PR #14808: URL: https://github.com/apache/lucene/pull/14808#issuecomment-2985485459 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop

[PR] Add support for running ast-grep rules [lucene]

2025-06-18 Thread via GitHub
dweiss opened a new pull request, #14808: URL: https://github.com/apache/lucene/pull/14808 This is a spinoff from #14804. We should allow running ```ast-grep``` (https://ast-grep.github.io/) rules as validation checks. This is a powerful tool (and fast). For now, running ast-grep is